Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vorta displays the same name for all archives #2041

Open
2 tasks done
romlok opened this issue Jul 19, 2024 · 4 comments · May be fixed by #2213
Open
2 tasks done

Vorta displays the same name for all archives #2041

romlok opened this issue Jul 19, 2024 · 4 comments · May be fixed by #2213
Labels
type:bug Something doesn't work as intended
Milestone
v0.11 (Next major...

Comments

@romlok
Copy link

romlok commented Jul 19, 2024

Description

  1. Go to "Archives" tab
  2. Double-click an archive name
  3. Press escape to abort editing the name
  4. Click "extract" for an archive
  5. ⚠️ All archives get given name of the double-clicked archive ⚠️
  6. The extract window appears

This also affects any archives created after this point too.

Screenshot_20240719_150220-1

The archives aren't actually renamed, as quitting and restarting Vorta will have them return to their correct names.
However, in the bugged state, the incorrect names will be used for other functions, such as diffing (which results in an exception because it expects the names to be unique keys).

Reproduction

  • I tried to reproduce the issue.
  • I was able to reproduce the issue.

OS

Debian Testing, KDE Plasma 5.27.11

Version of Vorta

0.9.1

What did you install Vorta with?

Distribution package

Version of Borg

1.4.0

Logs

2024-07-19 15:14:28,563 - vorta.keyring.abc - DEBUG - No module named 'objc'
2024-07-19 15:14:28,585 - vorta.keyring.abc - DEBUG - Using VortaKWallet5Keyring
2024-07-19 15:14:28,585 - vorta.borg.borg_job - DEBUG - Using VortaKWallet5Keyring keyring to store passwords.
2024-07-19 15:14:28,586 - vorta.keyring.kwallet - DEBUG - Retrieved password for repo ssh://[email protected]/./repo
2024-07-19 15:14:28,594 - vorta.borg.jobs_manager - DEBUG - Add job for site 2
2024-07-19 15:14:28,594 - vorta.borg.jobs_manager - DEBUG - Start job on site: 2
2024-07-19 15:14:28,603 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg list --info --log-json --json-lines --format {mode}{user}{group}{size}{isomtime}{path}{source}{health}{NL} ssh://[email protected]/./repo::elyvilon-2024-07-17-182346
2024-07-19 15:14:30,105 - vorta.borg.jobs_manager - DEBUG - Finish job for site: 2
2024-07-19 15:14:30,105 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: 2
2024-07-19 15:14:30,106 - vorta.scheduler - INFO - Setting timer for profile 1
2024-07-19 15:14:30,106 - vorta.scheduler - DEBUG - Scheduling next run for 2024-07-19 21:39:55.077533
@m3nu m3nu added the type:bug Something doesn't work as intended label Jul 19, 2024
@m3nu
Copy link
Contributor

m3nu commented Jul 19, 2024

Nice find! Can you check this out, @shivansh02 ? Has a good description and would be pretty serious.

@shivansh02
Copy link
Collaborator

@m3nu The only solution I could come up with is setting renamed_archive_original_name = None before all the actions(recalc, extract, etc) using a decorator/helper function. I'm not sure if its the best solution though.

@m3nu
Copy link
Contributor

m3nu commented Jul 22, 2024

Thanks for looking into it. That doesn't sound too good. Without knowing the details, could we catch the escape-event somewhere to deal with it properly? They should be one or more Qt events for it.

@kk7ds
Copy link

kk7ds commented Jan 11, 2025

I see this as well on 0.10.3 ... Took me about an hour to figure out what was going on before realizing it was just being displayed improperly and then found this ticket.

@szpak szpak mentioned this issue Feb 26, 2025
Closed
@m3nu m3nu added this to the v0.11 (Next major release) milestone Feb 27, 2025
@VandalByte VandalByte linked a pull request Mar 6, 2025 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something doesn't work as intended
Projects
None yet
Milestone
v0.11 (Next major release)
Development

Successfully merging a pull request may close this issue.

Fix bug with incorrect renaming of archives after aborting edit VandalByte/vorta
4 participants
@romlok @kk7ds @m3nu @shivansh02