Skip to content

Remove Paramiko Dependency #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m3nu opened this issue Jan 21, 2023 · 6 comments · Fixed by #1606
Closed

Remove Paramiko Dependency #1559

m3nu opened this issue Jan 21, 2023 · 6 comments · Fixed by #1606
Assignees
Labels
status:planning For large features, plan it out before implementation type:enhancement Improvement of an existing function

Comments

@m3nu
Copy link
Contributor

m3nu commented Jan 21, 2023

This is a heavy depdency and we only use it to verify a file is a SSH key. Would favor removing it and just checking files for starting with -----BEGIN OPENSSH PRIVATE KEY-----.

And check for common SSH issues, like wrong ownership or permissions.

Related : #167

@m3nu m3nu added type:enhancement Improvement of an existing function status:planning For large features, plan it out before implementation labels Jan 21, 2023
@real-yfprojects
Copy link
Collaborator

@m3nu
Copy link
Contributor Author

m3nu commented Jan 21, 2023

Nice. So this confirms the first line. Then I'd just use that to verify the file and not show the key format (doesn't add much value). Most users will just keep it on Default anyways. Algo to populate the dropdown would be like this:

  1. Grab files in ~/.ssh
  2. Ignore config and known_hosts*. And *.pub
  3. For other files read first line.
  4. If it matches, show the filename in dropdown.

Right?

@diivi
Copy link
Contributor

diivi commented Feb 22, 2023

Hi, I would like to work on this issue, please assign it to me, thanks!

@m3nu
Copy link
Contributor Author

m3nu commented Feb 22, 2023

Done

@diivi diivi mentioned this issue Feb 22, 2023
9 tasks
@diivi
Copy link
Contributor

diivi commented Mar 21, 2023

This can be closed now.

@real-yfprojects real-yfprojects linked a pull request Mar 21, 2023 that will close this issue
9 tasks
@real-yfprojects
Copy link
Collaborator

Fixed by #1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:planning For large features, plan it out before implementation type:enhancement Improvement of an existing function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants