Skip to content

feat: font 적용방법 수정 #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: font 적용방법 수정 #197

wants to merge 1 commit into from

Conversation

Lukaid-dev
Copy link
Collaborator

@Lukaid-dev Lukaid-dev commented Dec 10, 2023

다른 이슈가 발견되어 머지는 좀 미룹니다...

Checklist

  • Code Review: 작성한 코드를 다시 한 번 꼼꼼이 확인했나요?
  • Testing: 앱이 잘 구동되는지 개발한 기능이 문제 없이 작동하는지 확인했나요?
  • Remove: print나 주석 등 필요없는 코드를 삭제했나요?

Description

폰트 적용 방식을 수정했습니다. 우선 이렇게 해보고 다양한 환경에서 테스트 해본 후 해결되지 않으면 다른 방법을 적용해볼게요. 일단 제 환경에선 잘 되네요

close #196

Changes Made

client/src/styles/fonts.css

  • font를 명시적으로 불러옴

client/src/styles/fonts/Pretendard-Bold.otf

  • 폰트파일을 public에서 src내로 옮김

client/tailwind.config.js

  • 정확히 무슨차이인지는 모르겠지만, 많은 레퍼런스에서 extend에 fontFamily를 두고있는것을 참고함

@Lukaid-dev Lukaid-dev self-assigned this Dec 10, 2023
Copy link
Collaborator

@kiuuon kiuuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전 맥북에서 pretendard 잘 적용 됩니다. 아이폰으로도 봤는데 적용 잘 되는것 같습니다!
LGTM 👍

Copy link
Collaborator

@glowisn glowisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM!

@vimkim vimkim deleted the branch develop February 5, 2024 10:38
@vimkim vimkim closed this Feb 5, 2024
@vimkim vimkim deleted the refactor/font branch March 14, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: 폰트 정리
4 participants