Skip to content

Really need to go parent define and go to implements for property and method. #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xpader opened this issue Mar 29, 2021 · 6 comments
Closed

Comments

@xpader
Copy link

xpader commented Mar 29, 2021

We can use Find All References and Find All Implements, but this is only search down implements.

We really need up search override property and method where it's define.

Hope we can have up search and down search for property and method.

Screenshot in phpStorm:

屏幕截图 2021-03-29 120220
屏幕截图 2021-03-29 120139

@bmewburn
Copy link
Owner

Does go to declaration resolve this?

go_to_declaration

@xpader
Copy link
Author

xpader commented Mar 30, 2021

Not just like that, It can go up and up again by click the method or property. For example, you can click foo() in SubType to found up define in SuperType just like click parent::foo(), not the instance of SubType.

These really help for read framework codes, or implement Class.

phpstorm

@bmewburn
Copy link
Owner

Sounds like type/method hierarchy support. I don't think this has been specified in the Language Server Protocol yet. There's an issue tracking it here microsoft/language-server-protocol#136 .

@mrcwebdesign
Copy link

I think they support it now.

@xpader
Copy link
Author

xpader commented Jun 14, 2024

@bmewburn Consider to implement this?

@bmewburn
Copy link
Owner

@xpader looking into it but there's a few challenges in that vscode/lsp does not have an api for it yet. will track this in #1249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants