Skip to content

Commit 1d8bd86

Browse files
marco-ippolitobmeck
authored andcommitted
util: move util.isObject to eol
PR-URL: nodejs#52744 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 0bdf318 commit 1d8bd86

File tree

4 files changed

+5
-53
lines changed

4 files changed

+5
-53
lines changed

doc/api/deprecations.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -1204,6 +1204,9 @@ The `util.isNumber()` API has been removed. Please use
12041204

12051205
<!-- YAML
12061206
changes:
1207+
- version: REPLACEME
1208+
pr-url: https://github.com/nodejs/node/pull/52744
1209+
description: End-of-Life deprecation.
12071210
- version: v22.0.0
12081211
pr-url: https://github.com/nodejs/node/pull/50488
12091212
description: Runtime deprecation.
@@ -1219,9 +1222,9 @@ changes:
12191222
description: Documentation-only deprecation.
12201223
-->
12211224

1222-
Type: Runtime
1225+
Type: End-of-Life
12231226

1224-
The [`util.isObject()`][] API is deprecated. Please use
1227+
The `util.isObject()` API has been removed. Please use
12251228
`arg && typeof arg === 'object'` instead.
12261229

12271230
### DEP0054: `util.isPrimitive()`
@@ -3805,7 +3808,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
38053808
[`util.isArray()`]: util.md#utilisarrayobject
38063809
[`util.isError()`]: util.md#utiliserrorobject
38073810
[`util.isFunction()`]: util.md#utilisfunctionobject
3808-
[`util.isObject()`]: util.md#utilisobjectobject
38093811
[`util.isPrimitive()`]: util.md#utilisprimitiveobject
38103812
[`util.log()`]: util.md#utillogstring
38113813
[`util.promisify`]: util.md#utilpromisifyoriginal

doc/api/util.md

-30
Original file line numberDiff line numberDiff line change
@@ -3045,36 +3045,6 @@ util.isFunction(Bar);
30453045
// Returns: true
30463046
```
30473047
3048-
### `util.isObject(object)`
3049-
3050-
<!-- YAML
3051-
added: v0.11.5
3052-
deprecated: v4.0.0
3053-
-->
3054-
3055-
> Stability: 0 - Deprecated:
3056-
> Use `value !== null && typeof value === 'object'` instead.
3057-
3058-
* `object` {any}
3059-
* Returns: {boolean}
3060-
3061-
Returns `true` if the given `object` is strictly an `Object` **and** not a
3062-
`Function` (even though functions are objects in JavaScript).
3063-
Otherwise, returns `false`.
3064-
3065-
```js
3066-
const util = require('node:util');
3067-
3068-
util.isObject(5);
3069-
// Returns: false
3070-
util.isObject(null);
3071-
// Returns: false
3072-
util.isObject({});
3073-
// Returns: true
3074-
util.isObject(() => {});
3075-
// Returns: false
3076-
```
3077-
30783048
### `util.isPrimitive(object)`
30793049
30803050
<!-- YAML

lib/util.js

-13
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,6 @@ function lazyAbortController() {
9090

9191
let internalDeepEqual;
9292

93-
/**
94-
* @deprecated since v4.0.0
95-
* @param {any} arg
96-
* @returns {a is NonNullable<object>}
97-
*/
98-
function isObject(arg) {
99-
return arg !== null && typeof arg === 'object';
100-
}
101-
10293
/**
10394
* @deprecated since v4.0.0
10495
* @param {any} e
@@ -363,10 +354,6 @@ module.exports = {
363354
}
364355
return internalDeepEqual(a, b);
365356
},
366-
isObject: deprecate(isObject,
367-
'The `util.isObject` API is deprecated. ' +
368-
'Please use `arg !== null && typeof arg === "object"` instead.',
369-
'DEP0053'),
370357
isDate: deprecate(types.isDate,
371358
'The `util.isDate` API is deprecated. Please use `arg instanceof Date` instead.',
372359
'DEP0047'),

test/parallel/test-util.js

-7
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,6 @@ assert.strictEqual(util.isError({ name: 'Error', message: '' }), false);
6262
assert.strictEqual(util.isError([]), false);
6363
assert.strictEqual(util.isError({ __proto__: Error.prototype }), true);
6464

65-
// isObject
66-
assert.strictEqual(util.isObject({}), true);
67-
assert.strictEqual(util.isObject([]), true);
68-
assert.strictEqual(util.isObject(new Number(3)), true);
69-
assert.strictEqual(util.isObject(Number(4)), false);
70-
assert.strictEqual(util.isObject(1), false);
71-
7265
// isPrimitive
7366
assert.strictEqual(util.isPrimitive({}), false);
7467
assert.strictEqual(util.isPrimitive(new Error()), false);

0 commit comments

Comments
 (0)