deprecate get_client and get_multi_client (solana-labs#177)

gregcusack · web-flow · commit 00c984fe4dec · 2024-03-11T13:13:56.000-04:00
deprecate get_client and get_multi_client
diff --git a/dos/src/main.rs b/dos/src/main.rs
@@ -39,6 +39,7 @@
 //! ```
 //!
 #![allow(clippy::arithmetic_side_effects)]
+#![allow(deprecated)]
 use {
     crossbeam_channel::{select, tick, unbounded, Receiver, Sender},
     itertools::Itertools,
diff --git a/gossip/src/gossip_service.rs b/gossip/src/gossip_service.rs
@@ -194,6 +194,7 @@ pub fn discover(
 }
 
 /// Creates a ThinClient by selecting a valid node at random
+#[deprecated(since = "1.18.0", note = "Interface will change")]
 pub fn get_client(
     nodes: &[ContactInfo],
     socket_addr_space: &SocketAddrSpace,
@@ -209,6 +210,7 @@ pub fn get_client(
     ThinClient::new(rpc, tpu, connection_cache)
 }
 
+#[deprecated(since = "1.18.0", note = "Will be removed in favor of get_client")]
 pub fn get_multi_client(
     nodes: &[ContactInfo],
     socket_addr_space: &SocketAddrSpace,

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,7 @@ pub fn discover(`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`/// Creates a ThinClient by selecting a valid node at random`
	`197`	`+#[deprecated(since = "1.18.0", note = "Interface will change")]`
`197`	`198`	`pub fn get_client(`
`198`	`199`	`nodes: &[ContactInfo],`
`199`	`200`	`socket_addr_space: &SocketAddrSpace,`
`@@ -209,6 +210,7 @@ pub fn get_client(`
`209`	`210`	`ThinClient::new(rpc, tpu, connection_cache)`
`210`	`211`	`}`
`211`	`212`
	`213`	`+#[deprecated(since = "1.18.0", note = "Will be removed in favor of get_client")]`
`212`	`214`	`pub fn get_multi_client(`
`213`	`215`	`nodes: &[ContactInfo],`
`214`	`216`	`socket_addr_space: &SocketAddrSpace,`