Skip to content

Commit 8993a3c

Browse files
[node] trim down values to only what is required for esbuild wrapping logic (vercel#8260)
The edge runtime context we were providing was necessary to have `ncc`-bundled code run, but after switching to `esbuild`, we didn't update this list. This PR trims the values down to only what's necessary for `esbuild`-bundled code to run. It also adds comments about why these values are necessary.
1 parent 57241aa commit 8993a3c

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

packages/node/src/dev-server.ts

+6-4
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,12 @@ async function createEdgeRuntime(params?: {
245245
Object.assign(
246246
context,
247247
{
248-
__dirname: '',
249-
module: {
250-
exports: {},
251-
},
248+
// This is required for esbuild wrapping logic to resolve
249+
module: {},
250+
251+
// This is required for environment variable access.
252+
// In production, env var access is provided by static analysis
253+
// so that only the used values are available.
252254
process: {
253255
env: process.env,
254256
},

0 commit comments

Comments
 (0)