[PM-15621] Ready for app code review.

Author: JimmyVo16

src/Api/AdminConsole/Controllers/OrganizationUsersController.cs

@@ -23,6 +23,7 @@
 using Bit.Core.Exceptions;
 using Bit.Core.Models.Business;
 using Bit.Core.Models.Commands;
+using Bit.Core.Models.Data.Organizations;
 using Bit.Core.Models.Data.Organizations.OrganizationUsers;
 using Bit.Core.OrganizationFeatures.OrganizationSubscriptions.Interface;
 using Bit.Core.OrganizationFeatures.OrganizationUsers.Interfaces;
@@ -595,6 +596,12 @@ public async Task<IActionResult> DeleteAccount(Guid orgId, Guid id)
 
         var result = await _deleteManagedOrganizationUserAccountCommand.DeleteUserAsync(orgId, id, currentUser.Id);
 
+        if (result is Success<DeleteUserResponse>)
+        {
+            return Ok();
+
+        }
+
         return result.MapToActionResultWithSingleErrorMessage();
     }
 

src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/DeleteManagedOrganizationUserAccountCommand.cs

@@ -13,6 +13,7 @@
 using Bit.Core.Tools.Enums;
 using Bit.Core.Tools.Models.Business;
 using Bit.Core.Tools.Services;
+using Microsoft.Extensions.Logging;
 
 
 namespace Bit.Core.AdminConsole.OrganizationFeatures.OrganizationUsers;
@@ -27,6 +28,7 @@ public class DeleteManagedOrganizationUserAccountCommand : IDeleteManagedOrganiz
     private readonly IOrganizationUserRepository _organizationUserRepository;
     private readonly IUserRepository _userRepository;
     private readonly ICurrentContext _currentContext;
+    private readonly ILogger<DeleteManagedOrganizationUserAccountCommand> _logger;
     private readonly IReferenceEventService _referenceEventService;
     private readonly IPushNotificationService _pushService;
 
@@ -38,6 +40,7 @@ public DeleteManagedOrganizationUserAccountCommand(
         IOrganizationUserRepository organizationUserRepository,
         IUserRepository userRepository,
         ICurrentContext currentContext,
+        ILogger<DeleteManagedOrganizationUserAccountCommand> logger,
         IReferenceEventService referenceEventService,
         IPushNotificationService pushService)
     {
@@ -48,6 +51,7 @@ public DeleteManagedOrganizationUserAccountCommand(
         _organizationUserRepository = organizationUserRepository;
         _userRepository = userRepository;
         _currentContext = currentContext;
+        _logger = logger;
         _referenceEventService = referenceEventService;
         _pushService = pushService;
     }
@@ -184,9 +188,9 @@ private async Task CancelPremiumsAsync(List<Valid<DeleteUserValidationRequest>>
             {
                 await _userService.CancelPremiumAsync(user);
             }
-            catch (GatewayException)
+            catch (GatewayException exception)
             {
-
+                _logger.LogWarning(exception, "Failed to cancel the user's premium.");
             }
         }
     }

src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/DeleteManagedOrganizationUserAccountValidator.cs

@@ -116,7 +116,7 @@ private static ValidationResult<DeleteUserValidationRequest> EnsureUserStatusIsN
 
     private static ValidationResult<DeleteUserValidationRequest> PreventSelfDeletion(DeleteUserValidationRequest request)
     {
-        if (request.OrganizationUser?.UserId == request.DeletingUserId)
+        if (request.OrganizationUser.UserId == request.DeletingUserId)
         {
             return new Invalid<DeleteUserValidationRequest>(new BadRequestError<DeleteUserValidationRequest>("You cannot delete yourself.", request));
         }
@@ -126,7 +126,7 @@ private static ValidationResult<DeleteUserValidationRequest> PreventSelfDeletion
 
     private async Task<ValidationResult<DeleteUserValidationRequest>> EnsureOnlyOwnersCanDeleteOwnersAsync(DeleteUserValidationRequest request)
     {
-        if (request.OrganizationUser?.Type != OrganizationUserType.Owner)
+        if (request.OrganizationUser.Type != OrganizationUserType.Owner)
         {
             return new Valid<DeleteUserValidationRequest>(request);
         }