Skip to content

Commit b1c147e

Browse files
committed
Lint fixing 🤷 and some grammatical fixes.
1 parent 3b4d570 commit b1c147e

File tree

3 files changed

+16
-21
lines changed

3 files changed

+16
-21
lines changed

Cargo.lock

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

README.md

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -52,22 +52,21 @@ You can also browse the latest published documentation:
5252
The project is structured as a monorepo using cargo workspaces. Some of the more noteworthy crates
5353
are:
5454

55-
- [`bitwarden-api-api`](./crates/bitwarden-api-api/): Auto-generated API bindings for the API
55+
- [`bitwarden-api-api`](./crates/bitwarden-api-api): Auto-generated API bindings for the API
5656
server.
57-
- [`bitwarden-api-identity`](./crates/bitwarden-api-identity/): Auto-generated API bindings for the
57+
- [`bitwarden-api-identity`](./crates/bitwarden-api-identity): Auto-generated API bindings for the
5858
Identity server.
59-
- [`bitwarden-core`](./crates/bitwarden-core/): The core functionality consumed by the other crates.
60-
- [`bitwarden-crypto`](./crates/bitwarden-crypto/): Crypto library.
61-
- [`bitwarden-wasm-internal`](./crates/bitwarden-wasm-internal/): WASM bindings for the internal
59+
- [`bitwarden-core`](./crates/bitwarden-core): The core functionality consumed by the other crates.
60+
- [`bitwarden-crypto`](./crates/bitwarden-crypto): Crypto library.
61+
- [`bitwarden-wasm-internal`](./crates/bitwarden-wasm-internal): WASM bindings for the internal
6262
SDK.
63-
- [`bitwarden-uniffi`](./crates/bitwarden-uniffi/): Mobile bindings for swift and kotlin using
63+
- [`bitwarden-uniffi`](./crates/bitwarden-uniffi): Mobile bindings for swift and kotlin using
6464
[UniFFI](https://github.com/mozilla/uniffi-rs/).
6565

6666
## API Bindings
6767

68-
We autogenerate the server bindings using
69-
[openapi-generator](https://github.com/OpenAPITools/openapi-generator). To do this we first need to
70-
build the internal swagger documentation.
68+
We autogenerate the server bindings using[openapi-generator](https://github.com/OpenAPITools/openapi-generator).
69+
To do this, we first need to build the internal swagger documentation.
7170

7271
### Swagger generation
7372

@@ -83,14 +82,14 @@ ASPNETCORE_ENVIRONMENT=development dotnet swagger tofile --output ../../identity
8382

8483
### OpenApi Generator
8584

86-
To generate a new version of the bindings run the following script from the root of the SDK project.
85+
To generate a new version of the bindings, run the following script from the root of the SDK project.
8786

8887
```bash
8988
./support/build-api.sh
9089
```
9190

92-
This project uses customized templates which lives in the `support/openapi-templates` directory.
93-
These templates resolves some outstanding issues we've experienced with the rust generator. But we
91+
This project uses customized templates that live in the `support/openapi-templates` directory.
92+
These templates resolve some outstanding issues we've experienced with the rust generator. But we
9493
strive towards modifying the templates as little as possible to ease future upgrades.
9594

9695
### Note
@@ -102,8 +101,8 @@ strive towards modifying the templates as little as possible to ease future upgr
102101

103102
## Developer tools
104103

105-
This project recommends the use of certain developer tools, and also includes configurations for
106-
them to make developers lives easier. The use of these tools is optional and they might require a
104+
This project recommends the use of certain developer tools and includes configurations for
105+
them to make developers' lives easier. The use of these tools is optional, and they might require a
107106
separate installation step.
108107

109108
The list of developer tools is:
@@ -122,12 +121,12 @@ The list of developer tools is:
122121
## Formatting & Linting
123122

124123
This repository uses various tools to check formatting and linting before it's merged. It's
125-
recommended to run the checks prior to submitting a PR.
124+
recommended to run the checks before submitting a PR.
126125

127126
### Installation
128127

129-
Please see the [lint.yml](./.github/workflows/lint.yml) file for example installation commands &
130-
versions. Here are the cli tools we use:
128+
Please see the [lint.yml](./.github/workflows/lint.yml) file, for example, installation commands and versions. Here are the
129+
cli tools we use:
131130

132131
- Nightly [cargo fmt](https://github.com/rust-lang/rustfmt) and
133132
[cargo udeps](https://github.com/est31/cargo-udeps)

crates/bitwarden-collections/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ bitwarden-core = { workspace = true, features = ["internal"] }
2424
bitwarden-crypto = { workspace = true }
2525
bitwarden-error = { workspace = true }
2626
serde = { workspace = true }
27-
serde_json = { workspace = true }
28-
serde_repr = { workspace = true }
2927
thiserror = { workspace = true }
3028
tsify-next = { workspace = true, optional = true }
3129
uniffi = { workspace = true, optional = true }

0 commit comments

Comments
 (0)