[PM-6498] Fix vault autofill showing/hiding website icons. (#789)

Author: fedemkr

BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListEffect.swift

@@ -22,4 +22,7 @@ enum VaultAutofillListEffect: Equatable {
 
     /// Stream the autofill items for the user.
     case streamAutofillItems
+
+    /// Stream the show web icons setting.
+    case streamShowWebIcons
 }

BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListProcessor.swift

@@ -20,6 +20,7 @@ class VaultAutofillListProcessor: StateProcessor<
         & HasFido2CredentialStore
         & HasFido2UserInterfaceHelper
         & HasPasteboardService
+        & HasStateService
         & HasTimeProvider
         & HasVaultRepository
 
@@ -110,6 +111,10 @@ class VaultAutofillListProcessor: StateProcessor<
             await searchVault(for: text)
         case .streamAutofillItems:
             await streamAutofillItems()
+        case .streamShowWebIcons:
+            for await value in await services.stateService.showWebIconsPublisher().values {
+                state.showWebIcons = value
+            }
         }
     }
 

BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListProcessorTests.swift

@@ -13,6 +13,7 @@ class VaultAutofillListProcessorTests: BitwardenTestCase { // swiftlint:disable:
     var errorReporter: MockErrorReporter!
     var fido2CredentialStore: MockFido2CredentialStore!
     var fido2UserInterfaceHelper: MockFido2UserInterfaceHelper!
+    var stateService: MockStateService!
     var subject: VaultAutofillListProcessor!
     var vaultRepository: MockVaultRepository!
 
@@ -28,6 +29,7 @@ class VaultAutofillListProcessorTests: BitwardenTestCase { // swiftlint:disable:
         errorReporter = MockErrorReporter()
         fido2CredentialStore = MockFido2CredentialStore()
         fido2UserInterfaceHelper = MockFido2UserInterfaceHelper()
+        stateService = MockStateService()
         vaultRepository = MockVaultRepository()
 
         subject = VaultAutofillListProcessor(
@@ -39,6 +41,7 @@ class VaultAutofillListProcessorTests: BitwardenTestCase { // swiftlint:disable:
                 errorReporter: errorReporter,
                 fido2CredentialStore: fido2CredentialStore,
                 fido2UserInterfaceHelper: fido2UserInterfaceHelper,
+                stateService: stateService,
                 vaultRepository: vaultRepository
             ),
             state: VaultAutofillListState()
@@ -55,6 +58,7 @@ class VaultAutofillListProcessorTests: BitwardenTestCase { // swiftlint:disable:
         errorReporter = nil
         fido2CredentialStore = nil
         fido2UserInterfaceHelper = nil
+        stateService = nil
         subject = nil
         vaultRepository = nil
     }
@@ -247,6 +251,19 @@ class VaultAutofillListProcessorTests: BitwardenTestCase { // swiftlint:disable:
         XCTAssertEqual(errorReporter.errors.last as? BitwardenTestError, .example)
     }
 
+    /// `perform(_:)` with `.streamShowWebIcons` requests the value of the show
+    /// web icons parameter from the state service.
+    func test_perform_streamShowWebIcons() {
+        let task = Task {
+            await subject.perform(.streamShowWebIcons)
+        }
+
+        stateService.showWebIconsSubject.send(false)
+        waitFor(subject.state.showWebIcons == false)
+
+        task.cancel()
+    }
+
     /// `receive(_:)` with `.addTapped` navigates to the add item view.
     func test_receive_addTapped() {
         subject.receive(.addTapped(fromToolbar: false))

BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListView.swift

@@ -94,6 +94,9 @@ private struct VaultAutofillListSearchableView: View {
             .task {
                 await store.perform(.streamAutofillItems)
             }
+            .task {
+                await store.perform(.streamShowWebIcons)
+            }
             .task(id: store.state.searchText) {
                 await store.perform(.search(store.state.searchText))
             }