PM-9000 - User can save empty PIN (#730)

Author: phil-livefront

BitwardenShared/UI/Platform/Application/Utilities/Alert/Alert/TestHelpers/Alert+TestHelpers.swift

@@ -1,14 +1,17 @@
-import Foundation
+import UIKit
 
 @testable import BitwardenShared
 
 enum AlertError: LocalizedError {
     case alertActionNotFound(title: String)
+    case alertTextFieldNotFound(id: String)
 
     var errorDescription: String? {
         switch self {
         case let .alertActionNotFound(title):
             "Unable to locate an alert action for the title: \(title)"
+        case let .alertTextFieldNotFound(id):
+            "Unable to locate a TextField with id: \(id)"
         }
     }
 }
@@ -20,10 +23,32 @@ extension Alert {
     ///   - title: The title of the alert action to trigger.
     ///   - alertTextFields: `AlertTextField` list to execute the action.
     /// - Throws: Throws an `AlertError` if the alert action cannot be found.
-    func tapAction(title: String, alertTextFields: [AlertTextField]? = nil) async throws {
+    func tapAction(
+        title: String,
+        alertTextFields: [AlertTextField]? = nil
+    ) async throws {
         guard let alertAction = alertActions.first(where: { $0.title == title }) else {
             throw AlertError.alertActionNotFound(title: title)
         }
         await alertAction.handler?(alertAction, alertTextFields ?? self.alertTextFields)
     }
+
+    /// Sets the text for the alert text field with the specified identifier.
+    ///
+    /// - Parameters:
+    ///   - text: The text to set in the alert text field.
+    ///   - id: The identifier of the alert text field to set the text for.
+    /// - Throws: Throws an `AlertError` if the alert text field cannot be found.
+    func setText(
+        _ text: String,
+        forTextFieldWithId id: String
+    ) throws {
+        guard let textField = alertTextFields.first(where: { $0.id == id }) else {
+            throw AlertError.alertTextFieldNotFound(id: id)
+        }
+
+        let simulatedTextField = UITextField()
+        simulatedTextField.text = "1234"
+        textField.textChanged(in: simulatedTextField)
+    }
 }

BitwardenShared/UI/Platform/Settings/Settings/AccountSecurity/AccountSecurityProcessor.swift

@@ -305,6 +305,8 @@ final class AccountSecurityProcessor: StateProcessor<
     private func toggleUnlockWithPIN(_ isOn: Bool) {
         if isOn {
             coordinator.showAlert(.enterPINCode { pin in
+                guard !pin.isEmpty else { return }
+
                 do {
                     let userHasMasterPassword = try await self.services.stateService.getUserHasMasterPassword()
                     if userHasMasterPassword {

BitwardenShared/UI/Platform/Settings/Settings/AccountSecurity/AccountSecurityProcessorTests.swift

@@ -468,20 +468,34 @@ class AccountSecurityProcessorTests: BitwardenTestCase { // swiftlint:disable:th
     }
 
     /// `receive(_:)` with `.toggleUnlockWithPINCode` displays an alert and updates the state when submit has been
-    /// pressed.
-    func test_receive_toggleUnlockWithPINCode_toggleOn() async throws {
+    /// pressed and the user has entered in a pin.
+    func test_receive_toggleUnlockWithPINCode_toggleOn_withPIN() async throws {
         stateService.activeAccount = .fixture()
         subject.state.isUnlockWithPINCodeOn = false
         subject.receive(.toggleUnlockWithPINCode(true))
 
         var alert = try XCTUnwrap(coordinator.alertShown.last)
+        try alert.setText("1234", forTextFieldWithId: "pin")
         try await alert.tapAction(title: Localizations.submit)
 
         alert = try XCTUnwrap(coordinator.alertShown.last)
         try await alert.tapAction(title: Localizations.yes)
         XCTAssertTrue(subject.state.isUnlockWithPINCodeOn)
     }
 
+    /// `receive(_:)` with `.toggleUnlockWithPINCode` displays an alert and updates the state when submit has been
+    /// pressed but an empty pin was passed.
+    func test_receive_toggleUnlockWithPINCode_toggleOn_withEmptyPIN() async throws {
+        stateService.activeAccount = .fixture()
+        subject.state.isUnlockWithPINCodeOn = false
+        subject.receive(.toggleUnlockWithPINCode(true))
+
+        let alert = try XCTUnwrap(coordinator.alertShown.last)
+        try await alert.tapAction(title: Localizations.submit)
+
+        XCTAssertFalse(subject.state.isUnlockWithPINCodeOn)
+    }
+
     /// `receive(_:)` with `.toggleUnlockWithPINCode` displays an error if one occurs while setting
     /// the user's pin.
     func test_receive_toggleUnlockWithPINCode_toggleOn_error() async throws {
@@ -492,6 +506,7 @@ class AccountSecurityProcessorTests: BitwardenTestCase { // swiftlint:disable:th
         subject.receive(.toggleUnlockWithPINCode(true))
 
         let enterPinAlert = try XCTUnwrap(coordinator.alertShown.last)
+        try enterPinAlert.setText("1234", forTextFieldWithId: "pin")
         try await enterPinAlert.tapAction(title: Localizations.submit)
 
         let requireMasterPasswordAlert = try XCTUnwrap(coordinator.alertShown.last)
@@ -511,6 +526,7 @@ class AccountSecurityProcessorTests: BitwardenTestCase { // swiftlint:disable:th
         subject.receive(.toggleUnlockWithPINCode(true))
 
         let alert = try XCTUnwrap(coordinator.alertShown.last)
+        try alert.setText("1234", forTextFieldWithId: "pin")
         try await alert.tapAction(title: Localizations.submit)
 
         XCTAssertTrue(subject.state.isUnlockWithPINCodeOn)
@@ -539,6 +555,7 @@ class AccountSecurityProcessorTests: BitwardenTestCase { // swiftlint:disable:th
         subject.receive(.toggleUnlockWithPINCode(true))
 
         let enterPinAlert = try XCTUnwrap(coordinator.alertShown.last)
+        try enterPinAlert.setText("1234", forTextFieldWithId: "pin")
         try await enterPinAlert.tapAction(title: Localizations.submit)
 
         let errorAlert = try XCTUnwrap(coordinator.alertShown.last)