PM-18205: Removed "additional options" for secure note (#1358)

Author: ezimet-livefront

BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemDetailsView.swift

@@ -201,18 +201,23 @@ struct ViewItemDetailsView: View { // swiftlint:disable:this type_body_length
     @ViewBuilder private var notesSection: some View {
         if !store.state.notes.isEmpty {
             let notes = store.state.notes
-            SectionView(Localizations.additionalOptions) {
-                BitwardenTextValueField(
-                    title: Localizations.notes,
-                    value: notes,
-                    useUIKitTextView: true,
-                    copyButtonAccessibilityIdentifier: "CopyNotesButton",
-                    copyButtonAction: { store.send(.copyPressed(value: notes, field: .notes))
-                    }
-                )
-            }
+            let notesView = BitwardenTextValueField(
+                title: Localizations.notes,
+                value: notes,
+                useUIKitTextView: true,
+                copyButtonAccessibilityIdentifier: "CopyNotesButton",
+                copyButtonAction: { store.send(.copyPressed(value: notes, field: .notes))
+                }
+            )
             .accessibilityElement(children: .contain)
             .accessibilityIdentifier("CipherNotesLabel")
+            if store.state.type == .secureNote {
+                notesView
+            } else {
+                SectionView(Localizations.additionalOptions) {
+                    notesView
+                }
+            }
         }
     }
 

BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemView.swift

@@ -200,6 +200,7 @@ struct ViewItemView_Previews: PreviewProvider {
         ]
         state.isMasterPasswordRePromptOn = false
         state.name = "Example"
+        state.notes = "secure note"
         state.loginState.fido2Credentials = [
             .fixture(creationDate: Date(timeIntervalSince1970: 1_710_494_110)),
         ]
@@ -221,6 +222,16 @@ struct ViewItemView_Previews: PreviewProvider {
         return state
     }
 
+    static var secureNoteState: CipherItemState {
+        var state = CipherItemState(
+            existing: cipher,
+            hasPremium: true
+        )!
+        state.notes = "secure note"
+        state.type = .secureNote
+        return state
+    }
+
     static var sshKeyState: CipherItemState {
         var state = CipherItemState(
             existing: cipher,
@@ -261,6 +272,8 @@ struct ViewItemView_Previews: PreviewProvider {
 
         loginPreview
 
+        secureNotePreview
+
         sshKeyPreview
     }
 
@@ -308,6 +321,28 @@ struct ViewItemView_Previews: PreviewProvider {
         .previewDisplayName("Login")
     }
 
+    @ViewBuilder static var secureNotePreview: some View {
+        NavigationView {
+            ViewItemView(
+                store: Store(
+                    processor: StateProcessor(
+                        state: ViewItemState(
+                            loadingState: .data(secureNoteState)
+                        )
+                    )
+                ),
+                timeProvider: PreviewTimeProvider(
+                    fixedDate: Date(
+                        timeIntervalSinceReferenceDate: .init(
+                            1_695_000_011
+                        )
+                    )
+                )
+            )
+        }
+        .previewDisplayName("SecureNote")
+    }
+
     @ViewBuilder static var sshKeyPreview: some View {
         NavigationView {
             ViewItemView(

BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemViewTests.swift

@@ -569,6 +569,15 @@ class ViewItemViewTests: BitwardenTestCase { // swiftlint:disable:this type_body
         )
     }
 
+    /// Snapshots the previews for secure note types.
+    @MainActor
+    func test_snapshot_previews_secureNote() {
+        assertSnapshot(
+            of: ViewItemView_Previews.secureNotePreview,
+            as: .defaultPortrait
+        )
+    }
+
     /// Snapshots the previews for login types.
     @MainActor
     func test_snapshot_previews_sshKey() {