Merge branch 'release/3.7.2'

Author: Andreas Linde

Classes/BITCrashReportTextFormatter.m

@@ -298,7 +298,7 @@ + (NSString *)stringValueForCrashReport:(BITPLCrashReport *)report crashReporter
           lp64 = true;
           break;
       }
-    }
+    }    
   }
 
   {
@@ -344,10 +344,12 @@ + (NSString *)stringValueForCrashReport:(BITPLCrashReport *)report crashReporter
         processPath = report.processInfo.processPath;
 
         /* Remove username from the path */
+#if TARGET_IPHONE_SIMULATOR
         if ([processPath length] > 0)
           processPath = [processPath stringByAbbreviatingWithTildeInPath];
         if ([processPath length] > 0 && [[processPath substringToIndex:1] isEqualToString:@"~"])
           processPath = [NSString stringWithFormat:@"/Users/USER%@", [processPath substringFromIndex:1]];
+#endif
       }
 
       /* Parent Process Name */
@@ -562,11 +564,17 @@ + (NSString *)stringValueForCrashReport:(BITPLCrashReport *)report crashReporter
 
     /* Remove username from the image path */
     NSString *imageName = @"";
-    if (imageInfo.imageName && [imageInfo.imageName length] > 0)
+    if (imageInfo.imageName && [imageInfo.imageName length] > 0) {
+#if TARGET_IPHONE_SIMULATOR
       imageName = [imageInfo.imageName stringByAbbreviatingWithTildeInPath];
+#else
+      imageName = imageInfo.imageName;
+#endif
+    }
+#if TARGET_IPHONE_SIMULATOR
     if ([imageName length] > 0 && [[imageName substringToIndex:1] isEqualToString:@"~"])
       imageName = [NSString stringWithFormat:@"/Users/USER%@", [imageName substringFromIndex:1]];
-    
+#endif
     [text appendFormat: fmt,
      imageInfo.imageBaseAddress,
      imageInfo.imageBaseAddress + (MAX(1, imageInfo.imageSize) - 1), // The Apple format uses an inclusive range

Classes/BITFeedbackListViewController.m

@@ -81,6 +81,9 @@ @interface BITFeedbackListViewController () <BITFeedbackUserDataDelegate, BITFee
 @implementation BITFeedbackListViewController {
   NSInteger _deleteButtonSection;
   NSInteger _userButtonSection;
+  
+  NSInteger _numberOfSectionsBeforeRotation;
+  NSInteger _numberOfMessagesBeforeRotation;
 }
 
 - (instancetype)initWithStyle:(UITableViewStyle)style {
@@ -91,6 +94,10 @@ - (instancetype)initWithStyle:(UITableViewStyle)style {
     _userButtonSection = -1;
     _userDataComposeFlow = NO;
 
+    _numberOfSectionsBeforeRotation = -1;
+    _numberOfMessagesBeforeRotation = -1;
+    
+    
     _lastUpdateDateFormatter = [[NSDateFormatter alloc] init];
 		[_lastUpdateDateFormatter setDateStyle:NSDateFormatterShortStyle];
 		[_lastUpdateDateFormatter setTimeStyle:NSDateFormatterShortStyle];
@@ -394,8 +401,17 @@ - (void)feedbackComposeViewController:(BITFeedbackComposeViewController *)compos
 #pragma mark - UIViewController Rotation
 
 - (void)willRotateToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation duration:(NSTimeInterval)duration {
+  _numberOfSectionsBeforeRotation = [self numberOfSectionsInTableView:self.tableView];
+  _numberOfMessagesBeforeRotation = [self.manager numberOfMessages];
+  [self.tableView reloadData];
   [self.tableView beginUpdates];
   [self.tableView endUpdates];
+  
+  _numberOfSectionsBeforeRotation = -1;
+  _numberOfMessagesBeforeRotation = -1;
+  [self.tableView reloadData];
+  
+  [super willRotateToInterfaceOrientation:toInterfaceOrientation duration:duration];
 }
 
 - (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)orientation {
@@ -406,6 +422,9 @@ - (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)orientati
 #pragma mark - Table view data source
 
 - (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView {
+  if (_numberOfSectionsBeforeRotation >= 0)
+    return _numberOfSectionsBeforeRotation;
+  
   NSInteger sections = 2;
   _deleteButtonSection = -1;
   _userButtonSection = -1;
@@ -425,6 +444,8 @@ - (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView {
 
 - (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section {
   if (section == 1) {
+    if (_numberOfMessagesBeforeRotation >= 0)
+      return _numberOfMessagesBeforeRotation;
     return [self.manager numberOfMessages];
   } else {
     return 1;

Classes/BITFeedbackManager.h

@@ -228,7 +228,6 @@ typedef NS_ENUM(NSInteger, BITFeedbackObservationMode) {
  All NSString-Content in the array will be concatenated and result in the message,
  while all UIImage and NSData-instances will be turned into attachments.
  
- @param items an NSArray with objects that should be attached
  @see `[BITFeedbackComposeViewController prepareWithItems:]`
  */
 @property (nonatomic, copy) NSArray *feedbackComposerPreparedItems;

HockeySDK-Source.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name              = 'HockeySDK-Source'
-  s.version           = '3.7.1'
+  s.version           = '3.7.2'
 
   s.summary           = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.'
   s.description       = <<-DESC
@@ -12,7 +12,7 @@ Pod::Spec.new do |s|
                         DESC
 
   s.homepage          = 'http://hockeyapp.net/'
-  s.documentation_url = 'http://hockeyapp.net/help/sdk/ios/3.7.1/'
+  s.documentation_url = 'http://hockeyapp.net/help/sdk/ios/3.7.2/'
 
   s.license           = 'MIT'
   s.author            = { 'Andreas Linde' => '[email protected]', 'Thomas Dohmke' => "[email protected]" }
@@ -25,7 +25,7 @@ Pod::Spec.new do |s|
   s.frameworks              = 'AssetsLibrary', 'CoreText', 'CoreGraphics', 'MobileCoreServices', 'QuartzCore', 'QuickLook', 'Security', 'SystemConfiguration', 'UIKit'
   s.libraries = 'c++'
   s.ios.vendored_frameworks = 'Vendor/CrashReporter.framework'
-  s.xcconfig                = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_C_VERSION="\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"42\\"" BITHOCKEY_C_BUILD="\\"42\\""} }
+  s.xcconfig                = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_C_VERSION="\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"44\\"" BITHOCKEY_C_BUILD="\\"44\\""} }
   s.resource_bundle         = { 'HockeySDKResources' => ['Resources/*.png', 'Resources/*.lproj'] }
   s.preserve_paths          = 'Resources', 'Support'
   s.private_header_files  = 'Classes/*Private.h'

HockeySDK.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name              = 'HockeySDK'
-  s.version           = '3.7.1'
+  s.version           = '3.7.2'
 
   s.summary           = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.'
   s.description       = <<-DESC
@@ -12,7 +12,7 @@ Pod::Spec.new do |s|
                         DESC
 
   s.homepage          = 'http://hockeyapp.net/'
-  s.documentation_url = 'http://hockeyapp.net/help/sdk/ios/3.7.1/'
+  s.documentation_url = 'http://hockeyapp.net/help/sdk/ios/3.7.2/'
 
   s.license           = { :type => 'MIT', :file => 'HockeySDK-iOS/LICENSE' }
   s.author            = { 'Andreas Linde' => '[email protected]', 'Thomas Dohmke' => "[email protected]" }