Merge pull request #505 from bitstadium/develop

develop -> master

Author: Benjamin Scholtysik (Reimold)

Classes/BITChannel.m

@@ -14,7 +14,7 @@
 #import "BITDevice.h"
 #import "BITPersistencePrivate.h"
 #import "BITSender.h"
-#import <libkern/OSAtomic.h>
+#import <stdatomic.h>
 
 
 static char *const BITDataItemsOperationsQueue = "net.hockeyapp.senderQueue";
@@ -29,6 +29,8 @@
 static NSInteger const BITDebugMaxBatchSize = 5;
 static NSInteger const BITDebugBatchInterval = 3;
 
+typedef _Atomic(char*) atomic_charptr;
+
 NS_ASSUME_NONNULL_BEGIN
 
 @interface BITChannel ()
@@ -131,13 +133,12 @@ - (void)persistDataItemQueue:(char **)eventBuffer {
 
   // Make sure string (which points to BITTelemetryEventBuffer) is not changed.
   char *previousBuffer = NULL;
-  char *newEmptyString = NULL;
+  char *newEmptyString = strdup("");
   do {
-    newEmptyString = strdup("");
     previousBuffer = *eventBuffer;
 
     // This swaps pointers and makes sure eventBuffer now has the balue of newEmptyString.
-    if (OSAtomicCompareAndSwapPtr(previousBuffer, newEmptyString, (void*)eventBuffer)) {
+    if (atomic_compare_exchange_strong((atomic_charptr *)eventBuffer, &previousBuffer, newEmptyString)) {
       @synchronized(self) {
         self.dataItemCount = 0;
       }
@@ -403,7 +404,7 @@ void bit_appendStringToEventBuffer(NSString *string, char **eventBuffer) {
     asprintf(&newBuffer, "%s%.*s\n", previousBuffer, (int)MIN(string.length, (NSUInteger)INT_MAX), string.UTF8String);
 
     // Compare newBuffer and previousBuffer. If they point to the same address, we are safe to use them.
-    if (OSAtomicCompareAndSwapPtr(previousBuffer, newBuffer, (void*)eventBuffer)) {
+    if (atomic_compare_exchange_strong((atomic_charptr *)eventBuffer, &previousBuffer, newBuffer)) {
 
       // Free the intermediate pointer.
       free(previousBuffer);
@@ -417,16 +418,17 @@ void bit_appendStringToEventBuffer(NSString *string, char **eventBuffer) {
 }
 
 void bit_resetEventBuffer(char **eventBuffer) {
-  if (!eventBuffer) { return; }
+  if (!eventBuffer) {
+    return;
+  }
 
-  char *newEmptyString = NULL;
   char *prevString = NULL;
+  char *newEmptyString = strdup("");
   do {
     prevString = *eventBuffer;
-    newEmptyString = strdup("");
 
     // Compare pointers to strings to make sure we are still threadsafe!
-    if (OSAtomicCompareAndSwapPtr(prevString, newEmptyString, (void*)eventBuffer)) {
+    if (atomic_compare_exchange_strong((atomic_charptr *)eventBuffer, &prevString, newEmptyString)) {
       free(prevString);
       return;
     }

Classes/BITCrashManager.m

@@ -556,6 +556,7 @@ - (void) registerObservers {
             self.didLogLowMemoryWarning = YES;
           }
         });
+        dispatch_resume(source);
       });
     } else {
       self.appDidReceiveLowMemoryWarningObserver = [[NSNotificationCenter defaultCenter] addObserverForName:UIApplicationDidReceiveMemoryWarningNotification
@@ -1053,7 +1054,7 @@ - (void)triggerDelayedProcessing {
  */
 - (void)invokeDelayedProcessing {
 #if !defined (HOCKEYSDK_CONFIGURATION_ReleaseCrashOnlyExtensions)
-  if ([BITHockeyHelper applicationState] != BITApplicationStateActive) {
+  if (!bit_isRunningInAppExtension() && [BITHockeyHelper applicationState] != BITApplicationStateActive) {
     return;
   }
 #endif

Classes/BITFeedbackComposeViewController.m

@@ -155,11 +155,7 @@ - (void)keyboardWasShown:(NSNotification*)aNotification {
 
   CGRect frame = CGRectMake(0, 0, self.view.frame.size.width, self.view.frame.size.height);
   if (UI_USER_INTERFACE_IDIOM() != UIUserInterfaceIdiomPad) {
-    if (isPortraitOrientation) {
-      frame.size.height -= kbSize.height;
-    } else {
-      frame.size.height -= kbSize.width;
-    }
+    frame.size.height -= kbSize.height;
   } else {
     CGSize windowSize = [[UIScreen mainScreen] bounds].size;
     CGFloat windowHeight = windowSize.height - 20;
@@ -168,20 +164,19 @@ - (void)keyboardWasShown:(NSNotification*)aNotification {
     if (isPortraitOrientation) {
       frame.size.height = windowHeight - navBarHeight - kbSize.height;
     } else {
-      windowHeight = windowSize.width - 20;
+      windowHeight = windowSize.height - 20;
       CGFloat modalGap = 0.0;
-      if (windowHeight - kbSize.width < self.view.bounds.size.height) {
+      if (windowHeight - kbSize.height < self.view.bounds.size.height) {
         modalGap = 30;
       } else {
         modalGap = (windowHeight - self.view.bounds.size.height) / 2;
       }
-      frame.size.height = windowSize.width - navBarHeight - modalGap - kbSize.width;
+      frame.size.height = windowSize.height - navBarHeight - modalGap - kbSize.height;
     }
   }
   [self.contentViewContainer setFrame:frame];
 
   [self performSelector:@selector(refreshAttachmentScrollview) withObject:nil afterDelay:0.0];
-  
 }
 
 - (void)keyboardWillBeHidden:(NSNotification*) __unused aNotification {

Documentation/Guides/Changelog.md

@@ -1,3 +1,11 @@
+## 5.1.2
+
+- [IMPROVEMENT] This release uses Xcode 9.2 to compile the SDK. [#502](https://github.com/bitstadium/HockeySDK-iOS/pull/503)
+- [BUGFIX] Fix warnings when integrating the SDK as source in Xcode 9. [#501](https://github.com/bitstadium/HockeySDK-iOS/pull/501)
+- [BUGFIX] Fix a potential memory leak in `BITChannel`. [#500](https://github.com/bitstadium/HockeySDK-iOS/pull/500)
+- [BUGFIX] Version 5.1.X broke support for app extension. We're sorry about this and we've updated our test matrix to make sure this does not happen again. [#499](https://github.com/bitstadium/HockeySDK-iOS/pull/499)
+- [BUGFIX] Fix a bug in the Feedback UI when Feedback was shown in landscape. [#498](https://github.com/bitstadium/HockeySDK-iOS/pull/498)
+
 ## 5.1.1
 
 - [BUGFIX] Fixes a critical bug that would cause apps to freeze when calling `trackEvent` in UIApplicationDelegate callbacks. [#492](https://github.com/bitstadium/HockeySDK-iOS/pull/493)

Documentation/Guides/Installation & Setup.md

@@ -3,9 +3,9 @@
 [![Version](http://cocoapod-badges.herokuapp.com/v/HockeySDK/badge.png)](http://cocoadocs.org/docsets/HockeySDK)
  [![Slack Status](https://slack.hockeyapp.net/badge.svg)](https://slack.hockeyapp.net)
 
-## Version 5.1.1
+## Version 5.1.2
 
-- [Changelog](http://www.hockeyapp.net/help/sdk/ios/5.1.1/docs/docs/Changelog.html)
+- [Changelog](http://www.hockeyapp.net/help/sdk/ios/5.1.2/docs/docs/Changelog.html)
 
 **NOTE** If your are using the binary integration of our SDK, make sure that the `HockeySDKResources.bundle` inside the `HockeySDK.embeddedframework`-folder has been added to your application.
 
@@ -821,7 +821,7 @@ To check if data is send properly to HockeyApp and also see some additional SDK
 <a id="documentation"></a>
 ## 4. Documentation
 
-Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/5.1.1/index.html).
+Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/5.1.2/index.html).
 
 <a id="troubleshooting"></a>
 ## 5.Troubleshooting
@@ -835,7 +835,7 @@ Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/
   Make sure none of the following files are copied into your app bundle, check under app target, `Build Phases`, `Copy Bundle Resources` or in the `.app` bundle after building:
 
   - `HockeySDK.framework` (except if you build a dynamic framework version of the SDK yourself!)
-  - `de.bitstadium.HockeySDK-iOS-5.1.1.docset`
+  - `de.bitstadium.HockeySDK-iOS-5.1.2.docset`
 
 ### Features are not working as expected
 

Documentation/HockeySDK/.jazzy.yaml

@@ -5,7 +5,7 @@ sdk: iphonesimulator
 theme: ../Themes/apple
 
 module: HockeySDK
-module_version: 5.1.1
+module_version: 5.1.2
 author: Microsoft Corp
 author_url: https://www.microsoft.com
 

HockeySDK-Source.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name              = 'HockeySDK-Source'
-  s.version           = '5.1.1'
+  s.version           = '5.1.2'
 
   s.summary           = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.'
   s.description       = <<-DESC
@@ -25,7 +25,7 @@ Pod::Spec.new do |s|
   s.frameworks              = 'CoreGraphics', 'CoreTelephony', 'CoreText', 'MobileCoreServices', 'Photos', 'QuartzCore', 'QuickLook', 'Security', 'SystemConfiguration', 'UIKit'
   s.libraries = 'c++', 'z'
   s.vendored_frameworks = 'Vendor/CrashReporter.framework'
-  s.pod_target_xcconfig     = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_C_VERSION="\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"107\\"" BITHOCKEY_C_BUILD="\\"107\\""} }
+  s.pod_target_xcconfig     = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_C_VERSION="\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"108\\"" BITHOCKEY_C_BUILD="\\"108\\""} }
   s.resource_bundle         = { 'HockeySDKResources' => ['Resources/*.png', 'Resources/*.lproj'] }
   s.preserve_paths          = 'Resources', 'Support'
   s.private_header_files  = 'Classes/*Private.h'

HockeySDK.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name              = 'HockeySDK'
-  s.version           = '5.1.1'
+  s.version           = '5.1.2'
 
   s.summary           = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.'
   s.description       = <<-DESC

README.md

@@ -3,7 +3,7 @@
 [![Version](http://cocoapod-badges.herokuapp.com/v/HockeySDK/badge.png)](http://cocoadocs.org/docsets/HockeySDK)
 [![Slack Status](https://slack.hockeyapp.net/badge.svg)](https://slack.hockeyapp.net)
 
-## Version 5.1.1
+## Version 5.1.2
 
 HockeySDK-iOS implements support for using HockeyApp in your iOS applications.
 
@@ -23,13 +23,13 @@ The following features are currently supported:
 
 ## 1. Setup
 
-It is super easy to use HockeyApp in your iOS app. Have a look at our [documentation](https://www.hockeyapp.net/help/sdk/ios/5.1.1/index.html) and onboard your app within minutes.
+It is super easy to use HockeyApp in your iOS app. Have a look at our [documentation](https://www.hockeyapp.net/help/sdk/ios/5.1.2/index.html) and onboard your app within minutes.
 
 ## 2. Documentation
 
-Please visit [our landing page](https://www.hockeyapp.net/help/sdk/ios/5.1.1/index.html) as a starting point for all of our documentation.
+Please visit [our landing page](https://www.hockeyapp.net/help/sdk/ios/5.1.2/index.html) as a starting point for all of our documentation.
 
-Please check out our [changelog](http://www.hockeyapp.net/help/sdk/ios/5.1.1/changelog.html), as well as our [troubleshooting section](https://www.hockeyapp.net/help/sdk/ios/5.1.1/installation--setup.html#troubleshooting).
+Please check out our [changelog](http://www.hockeyapp.net/help/sdk/ios/5.1.2/changelog.html), as well as our [troubleshooting section](https://www.hockeyapp.net/help/sdk/ios/5.1.2/installation--setup.html#troubleshooting).
 
 ## 3. Contributing
 
@@ -53,4 +53,4 @@ You must sign a [Contributor License Agreement](https://cla.microsoft.com/) befo
 
 ## 4. Contact
 
-If you have further questions or are running into trouble that cannot be resolved by any of the steps [in our troubleshooting section](https://www.hockeyapp.net/help/sdk/ios/5.1.1/installation--setup.html#troubleshooting), feel free to open an issue here, contact us at [[email protected]](mailto:[email protected]) or join our [Slack](https://slack.hockeyapp.net).
+If you have further questions or are running into trouble that cannot be resolved by any of the steps [in our troubleshooting section](https://www.hockeyapp.net/help/sdk/ios/5.1.2/installation--setup.html#troubleshooting), feel free to open an issue here, contact us at [[email protected]](mailto:[email protected]) or join our [Slack](https://slack.hockeyapp.net).