Skip to content

Commit e1030dd

Browse files
committed
Note that reviewers should mention the commit hash of the commits they reviewed.
1 parent 5dc63ed commit e1030dd

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ Anyone may participate in peer review which is expressed by comments in the pull
9595
- Concept ACK means "I agree in the general principle of this pull request";
9696
- Nit refers to trivial, often non-blocking issues.
9797

98+
Reviewers should include the commit hash which they reviewed in their comments.
99+
98100
Project maintainers reserve the right to weigh the opinions of peer reviewers using common sense judgement and also may weight based on meritocracy: Those that have demonstrated a deeper commitment and understanding towards the project (over time) or have clear domain expertise may naturally have more weight, as one would expect in all walks of life.
99101

100102
Where a patch set affects consensus critical code, the bar will be set much higher in terms of discussion and peer review requirements, keeping in mind that mistakes could be very costly to the wider community. This includes refactoring of consensus critical code.

0 commit comments

Comments
 (0)