Skip to content

Commit 88f3505

Browse files
authored
fix: Bring back private keys logging (#1481)
**Description of the change** - Fixes missing log entries in the doc https://github.com/bitnami-labs/sealed-secrets/blob/main/docs/bring-your-own-certificates.md#see-the-new-certificates-private-keys-in-the-controller-logs **Benefits** <!-- What benefits will be realized by the code change? --> **Possible drawbacks** <!-- Describe any known limitations with your change --> **Applicable issues** <!-- Enter any applicable Issues here (You can reference an issue using #) --> - fixes 40c279f#r139767674 **Additional information** <!-- If there's anything else that's important and relevant to your pull request, mention that information here.--> Signed-off-by: Ivan Sabelnikov <[email protected]>
1 parent 0e8919a commit 88f3505

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

docs/bring-your-own-certificates.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ kubectl -n "$NAMESPACE" logs -l name=sealed-secrets-controller
4444
controller version: v0.12.1+dirty
4545
2020/06/09 14:30:45 Starting sealed-secrets controller version: v0.12.1+dirty
4646
2020/06/09 14:30:45 Searching for existing private keys
47-
2020/06/09 14:30:45 ----- sealed-secrets-key5rxd9
48-
2020/06/09 14:30:45 ----- mycustomkeys
47+
2020/06/09 14:30:45 registered private key secretname=sealed-secrets-key5rxd9
48+
2020/06/09 14:30:45 registered private key secretname=mycustomkeys
4949
2020/06/09 14:30:45 HTTP server serving on :8080
5050
```
5151

pkg/controller/main.go

+1
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ func initKeyRegistry(ctx context.Context, client kubernetes.Interface, r io.Read
9090
if err := keyRegistry.registerNewKey(secret.Name, key, certs[0], certs[0].NotBefore); err != nil {
9191
return nil, err
9292
}
93+
slog.Info("registered private key", "secretname", secret.Name)
9394
}
9495
return keyRegistry, nil
9596
}

0 commit comments

Comments
 (0)