You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bump github.com/onsi/ginkgo/v2 from 2.23.0 to 2.23.3 (#1711)
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from
2.23.0 to 2.23.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/onsi/ginkgo/releases">github.com/onsi/ginkgo/v2's
releases</a>.</em></p>
<blockquote>
<h2>v2.23.3</h2>
<h2>2.23.3</h2>
<h3>Fixes</h3>
<ul>
<li>allow <code>-</code> as a standalone argument [cfcc1a5]</li>
<li>Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context()
[feaf292]</li>
<li>ignore exit code for symbol test on linux [88e2282]</li>
</ul>
<h2>v2.23.2</h2>
<h2>2.23.2</h2>
<p>🎉🎉🎉</p>
<p>At long last, some long-standing performance gaps between
<code>ginkgo</code> and <code>go test</code> have been resolved!</p>
<p>Ginkgo operates by running <code>go test -c</code> to generate test
binaries, and then running those binaries. It turns out that the
compilation step of <code>go test -c</code> is slower than <code>go
test</code>'s compilation step because <code>go test</code> strips out
debug symbols (<code>ldflags=-w</code>) whereas <code>go test -c</code>
does not.</p>
<p>Ginkgo now passes the appropriate <code>ldflags</code> to <code>go
test -c</code> when running specs to strip out symbols. This is only
done when it is safe to do so and symbols are preferred when profiling
is enabled and when <code>ginkgo build</code> is called explicitly.</p>
<p>This, coupled, with the <a
href="https://onsi.github.io/ginkgo/#if-you-are-running-on-macos">instructions
for disabling XProtect on MacOS</a> yields a much better performance
experience with Ginkgo.</p>
<h2>v2.23.1</h2>
<h2>2.23.1</h2>
<h2>🚨 For users on MacOS 🚨</h2>
<p>A long-standing Ginkgo performance issue on MacOS seems to be due to
mac's antimalware XProtect. You can follow the instructions <a
href="https://onsi.github.io/ginkgo/#if-you-are-running-on-macos">here</a>
to disable it in your terminal. Doing so sped up Ginkgo's own test suite
from 1m8s to 47s.</p>
<h3>Fixes</h3>
<p>Ginkgo's CLI is now a bit clearer if you pass flags in
incorrectly:</p>
<ul>
<li>make it clearer that you need to pass a filename to the various
profile flags, not an absolute directory [a0e52ff]</li>
<li>emit an error and exit if the ginkgo invocation includes flags after
positional arguments [b799d8d]</li>
</ul>
<p>This might cause existing CI builds to fail. If so then it's likely
that your CI build was misconfigured and should be corrected. Open an
issue if you need help.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md">github.com/onsi/ginkgo/v2's
changelog</a>.</em></p>
<blockquote>
<h2>2.23.3</h2>
<h3>Fixes</h3>
<ul>
<li>allow <code>-</code> as a standalone argument [cfcc1a5]</li>
<li>Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context()
[feaf292]</li>
<li>ignore exit code for symbol test on linux [88e2282]</li>
</ul>
<h2>2.23.2</h2>
<p>🎉🎉🎉</p>
<p>At long last, some long-standing performance gaps between
<code>ginkgo</code> and <code>go test</code> have been resolved!</p>
<p>Ginkgo operates by running <code>go test -c</code> to generate test
binaries, and then running those binaries. It turns out that the
compilation step of <code>go test -c</code> is slower than <code>go
test</code>'s compilation step because <code>go test</code> strips out
debug symbols (<code>ldflags=-w</code>) whereas <code>go test -c</code>
does not.</p>
<p>Ginkgo now passes the appropriate <code>ldflags</code> to <code>go
test -c</code> when running specs to strip out symbols. This is only
done when it is safe to do so and symbols are preferred when profiling
is enabled and when <code>ginkgo build</code> is called explicitly.</p>
<p>This, coupled, with the <a
href="https://onsi.github.io/ginkgo/#if-you-are-running-on-macos">instructions
for disabling XProtect on MacOS</a> yields a much better performance
experience with Ginkgo.</p>
<h2>2.23.1</h2>
<h2>🚨 For users on MacOS 🚨</h2>
<p>A long-standing Ginkgo performance issue on MacOS seems to be due to
mac's antimalware XProtect. You can follow the instructions <a
href="https://onsi.github.io/ginkgo/#if-you-are-running-on-macos">here</a>
to disable it in your terminal. Doing so sped up Ginkgo's own test suite
from 1m8s to 47s.</p>
<h3>Fixes</h3>
<p>Ginkgo's CLI is now a bit clearer if you pass flags in
incorrectly:</p>
<ul>
<li>make it clearer that you need to pass a filename to the various
profile flags, not an absolute directory [a0e52ff]</li>
<li>emit an error and exit if the ginkgo invocation includes flags after
positional arguments [b799d8d]</li>
</ul>
<p>This might cause existing CI builds to fail. If so then it's likely
that your CI build was misconfigured and should be corrected. Open an
issue if you need help.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/onsi/ginkgo/commit/04a9a74a903f8346aec01c54818c617ad02197ab"><code>04a9a74</code></a>
v2.23.3</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/cfcc1a54014b8e077d9ee285038b73ff9763562c"><code>cfcc1a5</code></a>
allow <code>-</code> as a standalone argument</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/feaf292383aefea4a95ff7038a99764130127505"><code>feaf292</code></a>
Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context()</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/88e22820c3bf7593627a538e001d6a587e31c8b1"><code>88e2282</code></a>
ignore exit code for symbol test on linux</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/979c969fff919e8363a2ce7925465e028ebcab2f"><code>979c969</code></a>
v2.23.2</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/976a5c0dfc4a6770b899bfbe62174a07c32c8ad8"><code>976a5c0</code></a>
strip out symbols when running ginkgo</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/99e2fe223df0227f53ca0bc2afe1189fb3a5d654"><code>99e2fe2</code></a>
v2.23.1</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/a0e52ff9178d4290a29accfb36b4108b02997946"><code>a0e52ff</code></a>
make it clearer that you need to pass a filename to the various profile
flags...</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/b799d8d4c255f60f4678e2087c33582609366156"><code>b799d8d</code></a>
emit an error and exit if the ginkgo invocation includes flags after
position...</li>
<li><a
href="https://github.com/onsi/ginkgo/commit/a565d1f8ba417c363b8b429bd6c97da2219a7a7a"><code>a565d1f</code></a>
Fix typo in documentation: DescribeHandleSubtree ->
DescribeTableSubtree</li>
<li>Additional commits viewable in <a
href="https://github.com/onsi/ginkgo/compare/v2.23.0...v2.23.3">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?v=4&size=40){kind=avatar}
0 commit comments