Skip to content

Check/remove "address books" sync authority & content provider #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
rfc2822 opened this issue Jun 30, 2024 · 1 comment · Fixed by #877
Closed
2 tasks

Check/remove "address books" sync authority & content provider #871

rfc2822 opened this issue Jun 30, 2024 · 1 comment · Fixed by #877
Assignees
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Jun 30, 2024

Before using workers for automatic sync, we needed the "address books" sync authority and content provider so that sync intervals could be set for address books. As far as I remember, there was no other purpose.

  • Check whether "address books" sync authority and content provider is still needed.
  • If not, remove them.
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jun 30, 2024
@rfc2822 rfc2822 changed the title Remove "address books" sync authority & content provider Check/remove "address books" sync authority & content provider Jun 30, 2024
@sunkup sunkup self-assigned this Jul 2, 2024
@sunkup
Copy link
Member

sunkup commented Jul 2, 2024

I think it's actually possible to remove the address books authority and provider. I tried replacing all occurrences with ContactsContract.AUTHORITY and everything still works fine :)

I checked that the following still works:

  • Sync Adapter Framework initiated syncs on contact changes
  • changing sync intervals to periodic / manual

@sunkup sunkup linked a pull request Jul 2, 2024 that will close this issue
4 tasks
@sunkup sunkup moved this from Todo to In Review in DAVx⁵ Releases Jul 2, 2024
@sunkup sunkup moved this from In Review to In Progress in DAVx⁵ Releases Jul 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in DAVx⁵ Releases Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants