Skip to content

Provide callback instead of doing UI tasks of calling app #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
rfc2822 opened this issue Feb 13, 2025 · 1 comment
Closed
2 tasks

Provide callback instead of doing UI tasks of calling app #49

rfc2822 opened this issue Feb 13, 2025 · 1 comment
Assignees
@sunkup
Labels
refactoring Quality improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Feb 13, 2025

See bitfireAT/davx5-ose#1294 (comment):

  • cert4android shouldn't show the TrustCertificateActivity (and probably the notification) by itself, but instead should execute a callback that's provided by the calling application
  • cert4android then doesn't need to track "in foreground" anymore.
@rfc2822 rfc2822 added the refactoring Quality improvement of existing functions label Feb 13, 2025
@rfc2822 rfc2822 mentioned this issue Feb 13, 2025
Closed
4 tasks
@sunkup sunkup assigned sunkup and unassigned sunkup Feb 18, 2025
@sunkup sunkup linked a pull request Feb 19, 2025 that will close this issue
Provide callback instead of doing UI tasks of calling app #49 #50
Closed
@sunkup sunkup moved this from Todo to In Progress in DAVx⁵ Releases Feb 26, 2025
@sunkup sunkup moved this from In Progress to In Review in DAVx⁵ Releases Feb 26, 2025
@rfc2822 rfc2822 mentioned this issue Mar 1, 2025
Closed
@sunkup sunkup moved this from In Review to Todo in DAVx⁵ Releases Apr 9, 2025
@rfc2822
Copy link
Member Author

rfc2822 commented Apr 14, 2025

Closed for later

@rfc2822 rfc2822 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in DAVx⁵ Releases Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunkup sunkup

Labels
refactoring Quality improvement of existing functions
Projects
DAVx⁵ Releases
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide callback instead of doing UI tasks of calling app #49 bitfireAT/cert4android
2 participants
@rfc2822 @sunkup