Skip to content

Commit 345457b

Browse files
committed
Merge #25214: multiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory
44904aa multiprocess build cleanup: comment on manual dependencies (Ryan Ofsky) 6e1c16c multiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory (Ryan Ofsky) Pull request description: Error was reported by SatoriHoshiAiko in #25207 and happens unpredictably because make doesn't always build dependencies in the same order. The source file `src/ipc/capnp/protocol.cpp` includes some generated headers so needs to have an explicit dependency specified in the makefile so the headers will be generated before the file is compiled. #19160 added the explicit dependency, but it was incorrect because it referred to an old file path from before the source file was renamed (`ipc.cpp` -> `protocol.cpp`) ACKs for top commit: hebasto: re-ACK 44904aa Tree-SHA512: 578ef4ef35a97e9d8d4e6d4edf39e57a32674234bf145e8159268324cb6ba15b420517afc07f6f42bb11a562954ea74af686c3fb92ce178c1fc378421b352531
2 parents 3ba6dd6 + 44904aa commit 345457b

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/Makefile.am

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,6 @@ obj/build.h: FORCE
330330
"$(abs_top_srcdir)"
331331
libbitcoin_util_a-clientversion.$(OBJEXT): obj/build.h
332332

333-
ipc/capnp/libbitcoin_ipc_a-ipc.$(OBJEXT): $(libbitcoin_ipc_mpgen_input:=.h)
334333

335334
# server: shared between bitcoind and bitcoin-qt
336335
# Contains code accessing mempool and chain state that is meant to be separated
@@ -1012,6 +1011,10 @@ libbitcoin_ipc_mpgen_input = \
10121011
EXTRA_DIST += $(libbitcoin_ipc_mpgen_input)
10131012
%.capnp:
10141013

1014+
# Explicitly list dependencies on generated headers as described in
1015+
# https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html#Recording-Dependencies-manually
1016+
ipc/capnp/libbitcoin_ipc_a-protocol.$(OBJEXT): $(libbitcoin_ipc_mpgen_input:=.h)
1017+
10151018
if BUILD_MULTIPROCESS
10161019
LIBBITCOIN_IPC=libbitcoin_ipc.a
10171020
libbitcoin_ipc_a_SOURCES = \

0 commit comments

Comments
 (0)