Merge #22: Handle fork(2) failures

16ebae8 Handle fork(2) failures (Vasil Dimov)

Pull request description:

  Generate() and SpawnProcess() call fork(2) but did not check if it
  failed (return -1) and continued execution with possible unexpected
  results.

  Handle fork(2) failure by throwing an exception.

ACKs for top commit:
  ryanofsky:
    Tested ACK 16ebae8. Thanks for catching this, and also fixing more missing includes

Tree-SHA512: 72c9a6842772207e8617b7bfa69c2be3cde4888d1225391ee287510f0c5558ba5099369080a2dc638c2486161f21720f15f49477f897da5578ad8461a663489b

Author: ryanofsky

src/mp/gen.cpp

@@ -7,10 +7,12 @@
 
 #include <algorithm>
 #include <capnp/schema-parser.h>
+#include <errno.h>
 #include <fstream>
 #include <map>
 #include <set>
 #include <sstream>
+#include <system_error>
 #include <unistd.h>
 #include <vector>
 
@@ -137,6 +139,9 @@ void Generate(kj::StringPtr src_prefix,
     args.emplace_back("--output=" capnp_PREFIX "/bin/capnpc-c++");
     args.emplace_back(src_file);
     int pid = fork();
+    if (pid == -1) {
+        throw std::system_error(errno, std::system_category(), "fork");
+    }
     if (!pid) {
         mp::ExecProcess(args);
     }

src/mp/util.cpp

@@ -5,6 +5,7 @@
 #include <mp/config.h>
 #include <mp/util.h>
 
+#include <errno.h>
 #include <kj/array.h>
 #include <pthread.h>
 #include <sstream>
@@ -14,6 +15,7 @@
 #include <sys/types.h>
 #include <sys/un.h>
 #include <sys/wait.h>
+#include <system_error>
 #include <thread>
 #include <unistd.h>
 
@@ -101,6 +103,9 @@ int SpawnProcess(int& pid, FdToArgsFn&& fd_to_args)
     }
 
     pid = fork();
+    if (pid == -1) {
+        throw std::system_error(errno, std::system_category(), "fork");
+    }
     if (close(fds[pid ? 0 : 1]) != 0) {
         throw std::system_error(errno, std::system_category());
     }