Skip to content

Commit 3673114

Browse files
committed
proxy-types: fix clang-tidy bugprone-use-after-move error
include/mp/proxy-types.h:333:74: error: 'arg2' used after it was forwarded [bugprone-use-after-move,-warnings-as-errors] 333 | next_fn.handleChain(std::forward<Arg1>(arg1), std::forward<Arg2>(arg2), typename S::Second(), | ^ include/mp/proxy-types.h:332:9: note: forward occurred here 332 | handleChain(std::forward<Arg1>(arg1), std::forward<Arg2>(arg2), typename S::First());
1 parent 422923f commit 3673114

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

include/mp/proxy-types.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -326,18 +326,18 @@ template <typename Derived, size_t N = 0>
326326
struct IterateFieldsHelper
327327
{
328328
template <typename Arg1, typename Arg2, typename ParamList, typename NextFn, typename... NextFnArgs>
329-
void handleChain(Arg1&& arg1, Arg2&& arg2, ParamList, NextFn&& next_fn, NextFnArgs&&... next_fn_args)
329+
void handleChain(Arg1& arg1, Arg2& arg2, ParamList, NextFn&& next_fn, NextFnArgs&&... next_fn_args)
330330
{
331331
using S = Split<N, ParamList>;
332-
handleChain(std::forward<Arg1>(arg1), std::forward<Arg2>(arg2), typename S::First());
333-
next_fn.handleChain(std::forward<Arg1>(arg1), std::forward<Arg2>(arg2), typename S::Second(),
332+
handleChain(arg1, arg2, typename S::First());
333+
next_fn.handleChain(arg1, arg2, typename S::Second(),
334334
std::forward<NextFnArgs>(next_fn_args)...);
335335
}
336336

337337
template <typename Arg1, typename Arg2, typename ParamList>
338-
void handleChain(Arg1&& arg1, Arg2&& arg2, ParamList)
338+
void handleChain(Arg1& arg1, Arg2& arg2, ParamList)
339339
{
340-
static_cast<Derived*>(this)->handleField(std::forward<Arg1>(arg1), std::forward<Arg2>(arg2), ParamList());
340+
static_cast<Derived*>(this)->handleField(arg1, arg2, ParamList());
341341
}
342342
private:
343343
IterateFieldsHelper() = default;

0 commit comments

Comments
 (0)