Skip to content

Commit 745afc8

Browse files
chore: run biome on more than a few directories (#2099)
1 parent 89939ef commit 745afc8

25 files changed

+380
-365
lines changed

.github/workflows/ja-translation.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ jobs:
2323
${{ runner.os }}-
2424
- uses: pnpm/action-setup@v3
2525
- name: Install libraries
26-
working-directory: website
27-
run: pnpm i
26+
run: pnpm --filter @biomejs/website i
2827
- name: Run textlint
29-
working-directory: website
30-
run: pnpm textlint
28+
run: pnpm --filter @biomejs/website run textlint

.github/workflows/pull_request.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -135,17 +135,17 @@ jobs:
135135

136136
- name: Build TypeScript code
137137
run: |
138-
pnpm --prefix packages/@biomejs/backend-jsonrpc i
139-
pnpm --prefix packages/@biomejs/backend-jsonrpc run build
140-
pnpm --prefix packages/@biomejs/js-api run build:wasm-bundler
141-
pnpm --prefix packages/@biomejs/js-api run build:wasm-node
142-
pnpm --prefix packages/@biomejs/js-api run build:wasm-web
143-
pnpm --prefix packages/@biomejs/js-api i
144-
pnpm --prefix packages/@biomejs/js-api run build
138+
pnpm --filter @biomejs/backend-jsonrpc i
139+
pnpm --filter @biomejs/backend-jsonrpc run build
140+
pnpm --filter @biomejs/js-api run build:wasm-bundler
141+
pnpm --filter @biomejs/js-api run build:wasm-node
142+
pnpm --filter @biomejs/js-api run build:wasm-web
143+
pnpm --filter @biomejs/js-api i
144+
pnpm --filter @biomejs/js-api run build
145145
- name: Run JS tests
146146
run: |
147-
pnpm --prefix packages/@biomejs/backend-jsonrpc test:ci
148-
pnpm --prefix packages/@biomejs/js-api test:ci
147+
pnpm --filter @biomejs/backend-jsonrpc run test:ci
148+
pnpm --filter @biomejs/js-api run test:ci
149149
150150
documentation:
151151
name: Documentation

.github/workflows/pull_request_js.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
- name: Run Biome Format
4141
run: |
4242
pnpm i
43-
pnpm run check
43+
pnpm run ci
4444
4545
type-check:
4646
name: Type-check JS Files
@@ -65,8 +65,7 @@ jobs:
6565
- name: Build WASM module for the web
6666
run: wasm-pack build --out-dir ../../packages/@biomejs/wasm-web --target web --scope biomedev crates/biome_wasm
6767
- name: Install libraries
68-
working-directory: website
69-
run: pnpm i
68+
run: pnpm i --filter @biomejs/website
7069
- name: Build JS
7170
working-directory: website
7271
run: pnpm build:js

.github/workflows/release_js_api.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,17 +90,16 @@ jobs:
9090
9191
- name: Compile backends
9292
run: |
93-
pnpm --prefix packages/@biomejs/js-api build:wasm-bundler
94-
pnpm --prefix packages/@biomejs/js-api build:wasm-node
95-
pnpm --prefix packages/@biomejs/js-api build:wasm-web
96-
pnpm --prefix packages/@biomejs/backend-jsonrpc i
97-
pnpm --prefix packages/@biomejs/backend-jsonrpc run build
93+
pnpm --filter @biomejs/js-api run build:wasm-bundler
94+
pnpm --filter @biomejs/js-api run build:wasm-node
95+
pnpm --filter @biomejs/js-api run build:wasm-web
96+
pnpm --filter @biomejs/backend-jsonrpc i
97+
pnpm --filter @biomejs/backend-jsonrpc run build
9898
9999
- name: Build package
100-
working-directory: packages/@biomejs/js-api
101100
run: |
102-
pnpm i
103-
pnpm build
101+
pnpm --filter @biomejs/js-api i
102+
pnpm --filter @biomejs/js-api run build
104103
105104
- name: Upload JS API artifact
106105
uses: actions/upload-artifact@v3

.github/workflows/runtime.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,14 @@ jobs:
4141
- name: Install toolchain
4242
uses: moonrepo/setup-rust@v1
4343
- name: Install libraries
44-
working-directory: packages/@biomejs/js-api
45-
run: pnpm i
44+
run: pnpm --filter @biomejs/js-api i
4645
- name: Compile backends
4746
run: |
48-
pnpm --prefix packages/@biomejs/js-api build:wasm-bundler
49-
pnpm --prefix packages/@biomejs/js-api build:wasm-node
50-
pnpm --prefix packages/@biomejs/js-api build:wasm-web
51-
pnpm --prefix packages/@biomejs/backend-jsonrpc i
52-
pnpm --prefix packages/@biomejs/backend-jsonrpc run build
47+
pnpm --filter @biomejs/js-api run build:wasm-bundler
48+
pnpm --filter @biomejs/js-api run build:wasm-node
49+
pnpm --filter @biomejs/js-api run build:wasm-web
50+
pnpm --filter @biomejs/backend-jsonrpc i
51+
pnpm --filter @biomejs/backend-jsonrpc run build
5352
- name: CI checks
5453
working-directory: packages/@biomejs/js-api
5554
run: pnpm run ci

.npmrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# workaround until https://github.com/pnpm/pnpm/issues/6300 gets fixed
2+
dedupe-peer-dependents = false

benchmark/bench.biome.json

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
{
2+
"$schema": "../packages/@biomejs/biome/configuration_schema.json",
3+
"linter": {
4+
"enabled": true,
5+
"rules": {
6+
"recommended": false,
7+
"complexity": {
8+
"noExtraBooleanCast": "error"
9+
},
10+
"correctness": {
11+
"noArguments": "error",
12+
"noAsyncPromiseExecutor": "error",
13+
"noCatchAssign": "error",
14+
"noCompareNegZero": "error",
15+
"noDebugger": "error",
16+
"noDelete": "error",
17+
"noDoubleEquals": "error",
18+
"noDuplicateParameters": "error",
19+
"noEmptyPattern": "error",
20+
"noFunctionAssign": "error",
21+
"noImportAssign": "error",
22+
"noLabelVar": "error",
23+
"noMultipleSpacesInRegularExpressionLiterals": "error",
24+
"noNewSymbol": "error",
25+
"noRestrictedGlobals": "error",
26+
"noShadowRestrictedNames": "error",
27+
"noSparseArray": "error",
28+
"noUnreachable": "error",
29+
"noUnsafeNegation": "error",
30+
"noUnusedVariables": "error",
31+
"useValidTypeof": "error"
32+
},
33+
"nursery": {
34+
"noConstAssign": "warn",
35+
"useValidForDirection": "warn"
36+
}
37+
}
38+
}
39+
}

benchmark/bench.rome.json

Lines changed: 0 additions & 38 deletions
This file was deleted.

benchmark/dprint.json

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
{
22
"incremental": false,
3-
"typescript": {
4-
},
5-
"includes": ["**/*.{ts,tsx,js,jsx,cjs,mjs}"],
6-
"excludes": [
7-
"**/node_modules"
8-
],
9-
"plugins": [
10-
"https://plugins.dprint.dev/typescript-0.77.0.wasm"
11-
]
3+
"typescript": {},
4+
"includes": ["**/*.{ts,tsx,js,jsx,cjs,mjs}"],
5+
"excludes": ["**/node_modules"],
6+
"plugins": ["https://plugins.dprint.dev/typescript-0.77.0.wasm"]
127
}

benchmark/package.json

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
{
2-
"name": "benchmark",
3-
"version": "1.0.0",
4-
"description": "",
5-
"main": "run.js",
6-
"scripts": {
7-
"test": "echo \"Error: no test specified\" && exit 1"
8-
},
9-
"author": "",
10-
"license": "MIT OR Apache-2.0",
11-
"devDependencies": {
12-
"@mixer/parallel-prettier": "^2.0.3",
13-
"dprint": "^0.43.0",
14-
"eslint": "^8.54.0",
15-
"prettier": "^3.1.0"
16-
}
2+
"name": "@biomejs/benchmark",
3+
"version": "1.0.0",
4+
"description": "",
5+
"private": true,
6+
"main": "run.js",
7+
"author": "Biome Developers and Contributors",
8+
"license": "MIT OR Apache-2.0",
9+
"devDependencies": {
10+
"@mixer/parallel-prettier": "^2.0.3",
11+
"dprint": "^0.43.0",
12+
"eslint": "^8.54.0",
13+
"prettier": "^3.1.0"
14+
}
1715
}

0 commit comments

Comments
 (0)