Skip to content

Commit 73e88e6

Browse files
committed
Revert "Merge pull request Expensify#54593 from bernhardoj/fix/54335-dont-automatically-unpause-focus-trap"
This reverts commit 16ad2bc, reversing changes made to 7b9e55e. revert patch
1 parent 462f3c7 commit 73e88e6

File tree

3 files changed

+6
-52
lines changed

3 files changed

+6
-52
lines changed

patches/focus-trap+7.5.4.patch

Lines changed: 6 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,7 @@
11
diff --git a/node_modules/focus-trap/dist/focus-trap.esm.js b/node_modules/focus-trap/dist/focus-trap.esm.js
2-
index 10d56db..975151c 100644
2+
index 10d56db..a6d76d8 100644
33
--- a/node_modules/focus-trap/dist/focus-trap.esm.js
44
+++ b/node_modules/focus-trap/dist/focus-trap.esm.js
5-
@@ -71,12 +71,12 @@ var activeFocusTraps = {
6-
trapStack.push(trap);
7-
}
8-
},
9-
- deactivateTrap: function deactivateTrap(trapStack, trap) {
10-
+ deactivateTrap: function deactivateTrap(trapStack, trap, unpauseOnDeactivate) {
11-
var trapIndex = trapStack.indexOf(trap);
12-
if (trapIndex !== -1) {
13-
trapStack.splice(trapIndex, 1);
14-
}
15-
- if (trapStack.length > 0) {
16-
+ if (trapStack.length > 0 && unpauseOnDeactivate) {
17-
trapStack[trapStack.length - 1].unpause();
18-
}
19-
}
205
@@ -100,8 +100,8 @@ var isKeyForward = function isKeyForward(e) {
216
var isKeyBackward = function isKeyBackward(e) {
227
return isTabEvent(e) && e.shiftKey;
@@ -28,15 +13,7 @@ index 10d56db..975151c 100644
2813
};
2914

3015
// Array.find/findIndex() are not supported on IE; this replicates enough
31-
@@ -153,6 +153,7 @@ var createFocusTrap = function createFocusTrap(elements, userOptions) {
32-
var doc = (userOptions === null || userOptions === void 0 ? void 0 : userOptions.document) || document;
33-
var trapStack = (userOptions === null || userOptions === void 0 ? void 0 : userOptions.trapStack) || internalTrapStack;
34-
var config = _objectSpread2({
35-
+ unpauseOnDeactivate: true,
36-
returnFocusOnDeactivate: true,
37-
escapeDeactivates: true,
38-
delayInitialFocus: true,
39-
@@ -283,7 +284,7 @@ var createFocusTrap = function createFocusTrap(elements, userOptions) {
16+
@@ -283,7 +283,7 @@ var createFocusTrap = function createFocusTrap(elements, userOptions) {
4017
return node;
4118
};
4219
var getInitialFocusNode = function getInitialFocusNode() {
@@ -45,7 +22,7 @@ index 10d56db..975151c 100644
4522

4623
// false explicitly indicates we want no initialFocus at all
4724
if (node === false) {
48-
@@ -744,7 +745,7 @@ var createFocusTrap = function createFocusTrap(elements, userOptions) {
25+
@@ -744,7 +744,7 @@ var createFocusTrap = function createFocusTrap(elements, userOptions) {
4926
// that caused the focus trap activation.
5027
state.delayInitialFocusTimer = config.delayInitialFocus ? delay(function () {
5128
tryFocus(getInitialFocusNode());
@@ -54,16 +31,7 @@ index 10d56db..975151c 100644
5431
doc.addEventListener('focusin', checkFocusIn, true);
5532
doc.addEventListener('mousedown', checkPointerDown, {
5633
capture: true,
57-
@@ -868,7 +869,7 @@ var createFocusTrap = function createFocusTrap(elements, userOptions) {
58-
state.active = false;
59-
state.paused = false;
60-
updateObservedNodes();
61-
- activeFocusTraps.deactivateTrap(trapStack, trap);
62-
+ activeFocusTraps.deactivateTrap(trapStack, trap, config.unpauseOnDeactivate);
63-
var onDeactivate = getOption(options, 'onDeactivate');
64-
var onPostDeactivate = getOption(options, 'onPostDeactivate');
65-
var checkCanReturnFocus = getOption(options, 'checkCanReturnFocus');
66-
@@ -880,7 +881,7 @@ var createFocusTrap = function createFocusTrap(elements, userOptions) {
34+
@@ -880,7 +880,7 @@ var createFocusTrap = function createFocusTrap(elements, userOptions) {
6735
tryFocus(getReturnFocusNode(state.nodeFocusedBeforeActivation));
6836
}
6937
onPostDeactivate === null || onPostDeactivate === void 0 || onPostDeactivate();
@@ -73,7 +41,7 @@ index 10d56db..975151c 100644
7341
if (returnFocus && checkCanReturnFocus) {
7442
checkCanReturnFocus(getReturnFocusNode(state.nodeFocusedBeforeActivation)).then(finishDeactivation, finishDeactivation);
7543
diff --git a/node_modules/focus-trap/index.d.ts b/node_modules/focus-trap/index.d.ts
76-
index 400db1b..78b38d9 100644
44+
index 400db1b..69f4b94 100644
7745
--- a/node_modules/focus-trap/index.d.ts
7846
+++ b/node_modules/focus-trap/index.d.ts
7947
@@ -16,7 +16,7 @@ declare module 'focus-trap' {
@@ -85,19 +53,7 @@ index 400db1b..78b38d9 100644
8553

8654
type MouseEventToBoolean = (event: MouseEvent | TouchEvent) => boolean;
8755
type KeyboardEventToBoolean = (event: KeyboardEvent) => boolean;
88-
@@ -135,6 +135,11 @@ declare module 'focus-trap' {
89-
* in the trap.
90-
*/
91-
fallbackFocus?: FocusTarget;
92-
+ /**
93-
+ * By default, the previous focus trap on the stack will be unpaused
94-
+ * when the current active trap is deactivated.
95-
+ */
96-
+ unpauseOnDeactivate?: boolean;
97-
/**
98-
* Default: `true`. If `false`, when the trap is deactivated,
99-
* focus will *not* return to the element that had focus before activation.
100-
@@ -185,7 +190,7 @@ declare module 'focus-trap' {
56+
@@ -185,7 +185,7 @@ declare module 'focus-trap' {
10157
* This prevents elements within the focusable element from capturing
10258
* the event that triggered the focus trap activation.
10359
*/

src/components/FocusTrap/FocusTrapForModal/index.web.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ function FocusTrapForModal({children, active, initialFocus = false}: FocusTrapFo
1515
clickOutsideDeactivates: true,
1616
initialFocus,
1717
fallbackFocus: document.body,
18-
unpauseOnDeactivate: false,
1918
setReturnFocus: (element) => {
2019
if (ReportActionComposeFocusManager.isFocused()) {
2120
return false;

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ function FocusTrapForScreen({children, focusTrapSettings}: FocusTrapProps) {
5050
delayInitialFocus: CONST.ANIMATED_TRANSITION,
5151
initialFocus: false,
5252
setReturnFocus: false,
53-
unpauseOnDeactivate: false,
5453
...(focusTrapSettings?.focusTrapOptions ?? {}),
5554
}}
5655
>

0 commit comments

Comments
 (0)