Fix incorrect measurement callback argument in ConsoleReporter

I was incorrectly passing the entire `measurements` map instead of the
specific `measurement` for a metric to the `keep`/`drop` callbacks. This
fixes that issue and adds a test to verify.

Author: jaminthorns

lib/telemetry_metrics.ex

@@ -412,7 +412,7 @@ defmodule Telemetry.Metrics do
   @type tag_values :: (:telemetry.event_metadata() -> :telemetry.event_metadata())
   @type predicate_fun ::
           (:telemetry.event_metadata() -> boolean())
-          | (:telemetry.event_metadata(), :telemetry.event_measurements() -> boolean())
+          | (:telemetry.event_metadata(), :telemetry.event_value() -> boolean())
   @type keep :: predicate_fun()
   @type drop :: predicate_fun()
   @type description :: nil | String.t()

lib/telemetry_metrics/console_reporter.ex

@@ -100,7 +100,7 @@ defmodule Telemetry.Metrics.ConsoleReporter do
                   Measurement value missing (metric skipped)
                   """
 
-                not keep?(metric, metadata, measurements) ->
+                not keep?(metric, metadata, measurement) ->
                   """
                   Event dropped
                   """

test/console_reporter_test.exs

@@ -25,6 +25,9 @@ defmodule Telemetry.Metrics.ConsoleReporterTest do
           metadata[:boom] == :pow
         end
       ),
+      summary("parser.result.size",
+        keep: fn _metadata, measurement -> measurement > 1024 end
+      ),
       sum("telemetry.event_size.metadata",
         measurement: &__MODULE__.metadata_measurement/2
       ),
@@ -110,7 +113,7 @@ defmodule Telemetry.Metrics.ConsoleReporterTest do
            """
   end
 
-  test "filters events", %{device: device} do
+  test "filters events on metadata", %{device: device} do
     :telemetry.execute([:http, :request], %{response_time: 1000}, %{foo: :bar, boom: :pow})
     {_in, out} = StringIO.contents(device)
 
@@ -126,6 +129,32 @@ defmodule Telemetry.Metrics.ConsoleReporterTest do
            """
   end
 
+  test "filters events on measurement", %{device: device} do
+    :telemetry.execute([:parser, :result], %{size: 512})
+    :telemetry.execute([:parser, :result], %{size: 2048})
+    {_in, out} = StringIO.contents(device)
+
+    assert out == """
+           [Telemetry.Metrics.ConsoleReporter] Got new event!
+           Event name: parser.result
+           All measurements: %{size: 512}
+           All metadata: %{}
+
+           Metric measurement: :size (summary)
+           Event dropped
+
+           [Telemetry.Metrics.ConsoleReporter] Got new event!
+           Event name: parser.result
+           All measurements: %{size: 2048}
+           All metadata: %{}
+
+           Metric measurement: :size (summary)
+           With value: 2048
+           Tag values: %{}
+
+           """
+  end
+
   test "logs bad metrics", %{device: device} do
     log =
       capture_log(fn ->