Fix Rails/AssertNot to allow it to have message
#5894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
assert_not_awawre_failure_message
branch
from
38cd55a to
8314c98
Compare
Drenmi
reviewed
May 17, 2018
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * [#5894](https://github.com/bbatsov/rubocop/pull/5894): Fix `CustomCops/AssertNot` to allow it to have failure message. ([@koic][]) | |||
There was a problem hiding this comment.
This meant to be Rails/AssertNot? 🙂
There was a problem hiding this comment.
It is as you have pointed out. Thanks always!
Follow up of rails/rails@1dc17e7 This PR will make it aware about the case where failure message is used in `assert_not` method.
koic
force-pushed
the
assert_not_awawre_failure_message
branch
from
8314c98 to
a3bdf80
Compare
koic
changed the title
CustomCops/AssertNot to allow it to have messageRails/AssertNot to allow it to have message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of rails/rails@1dc17e7
This PR will make it aware about the case where failure message is used in
assert_notmethod.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.