[7.2.0] Disable path mapping with local or no-{sandbox,remote} tags (#22467)

Targets tagged with `local` or `no-sandbox` and `no-remote` can't
successfully use path mapping and thus have it disabled implicitly.

Closes #21921.

PiperOrigin-RevId: 635832339
Change-Id: Ib5cac0b202cbcd1704410f06fa3cda645581b849

Commit
46dce83

Co-authored-by: Fabian Meumertzheim <[email protected]>

Author: bazel-io

src/main/java/com/google/devtools/build/lib/analysis/actions/PathMappers.java

@@ -132,6 +132,12 @@ public static OutputPathsMode getOutputPathsMode(
 
   private static OutputPathsMode getEffectiveOutputPathsMode(
       OutputPathsMode outputPathsMode, String mnemonic, Map<String, String> executionInfo) {
+    if (executionInfo.containsKey(ExecutionRequirements.LOCAL)
+        || (executionInfo.containsKey(ExecutionRequirements.NO_SANDBOX)
+            && executionInfo.containsKey(ExecutionRequirements.NO_REMOTE))) {
+      // Path mapping requires sandboxed or remote execution.
+      return OutputPathsMode.OFF;
+    }
     if (outputPathsMode == OutputPathsMode.STRIP
         && (SUPPORTED_MNEMONICS.contains(mnemonic)
             || executionInfo.containsKey(ExecutionRequirements.SUPPORTS_PATH_MAPPING))) {

src/test/shell/bazel/path_mapping_test.sh

@@ -286,4 +286,43 @@ EOF
   expect_log '2 remote[^ ]'
 }
 
+function test_path_stripping_disabled_with_tags() {
+  mkdir pkg
+  cat > pkg/defs.bzl <<'EOF'
+def _my_rule_impl(ctx):
+    out = ctx.actions.declare_file(ctx.attr.name)
+    args = ctx.actions.args()
+    args.add(out)
+    ctx.actions.run_shell(
+         outputs = [out],
+         command = "echo 'Hello, World!' > $1",
+         arguments = [args],
+         execution_requirements = {"supports-path-mapping": ""},
+    )
+    return [
+        DefaultInfo(files = depset([out])),
+    ]
+
+my_rule = rule(_my_rule_impl)
+EOF
+  cat > pkg/BUILD << 'EOF'
+load(":defs.bzl", "my_rule")
+
+my_rule(
+    name = "local_target",
+    tags = ["local"],
+)
+
+my_rule(
+    name = "implicitly_local_target",
+    tags = [
+        "no-sandbox",
+        "no-remote",
+    ],
+)
+EOF
+
+  bazel build --experimental_output_paths=strip //pkg:all &> $TEST_log || fail "build failed unexpectedly"
+}
+
 run_suite "path mapping tests"