Skip to content

Commit cb6e5c2

Browse files
committed
Revert "Allow exec groups to inherit from the rule or other exec groups."
This reverts commit 3486b78. Signed-off-by: Philipp Wollermann <[email protected]>
1 parent 51fb9e1 commit cb6e5c2

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,16 +148,13 @@ public static LabelLateBoundDefault<BuildConfiguration> getCoverageOutputGenerat
148148
return runUnder != null ? runUnder.getLabel() : null;
149149
});
150150

151-
public static final String TEST_RUNNER_EXEC_GROUP = "test";
152-
153151
/**
154152
* A base rule for all test rules.
155153
*/
156154
public static final class TestBaseRule implements RuleDefinition {
157155
@Override
158156
public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment env) {
159157
return builder
160-
.addExecGroup(TEST_RUNNER_EXEC_GROUP)
161158
.requiresConfigurationFragments(TestConfiguration.class)
162159
// TestConfiguration only needed to create TestAction and TestProvider
163160
// Only necessary at top-level and can be skipped if trimmed.

src/main/java/com/google/devtools/build/lib/analysis/test/TestActionBuilder.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,12 @@
1414

1515
package com.google.devtools.build.lib.analysis.test;
1616

17-
import static com.google.devtools.build.lib.analysis.BaseRuleClasses.TEST_RUNNER_EXEC_GROUP;
1817
import static com.google.devtools.build.lib.packages.BuildType.LABEL;
1918

2019
import com.google.common.base.Preconditions;
2120
import com.google.common.collect.ImmutableList;
2221
import com.google.common.collect.Lists;
2322
import com.google.devtools.build.lib.actions.ActionInput;
24-
import com.google.devtools.build.lib.actions.ActionOwner;
2523
import com.google.devtools.build.lib.actions.Artifact;
2624
import com.google.devtools.build.lib.actions.ArtifactRoot;
2725
import com.google.devtools.build.lib.actions.RunfilesSupplier;
@@ -148,11 +146,6 @@ private boolean isPersistentTestRunner() {
148146
&& persistentTestRunnerRunfiles != null;
149147
}
150148

151-
private ActionOwner getOwner() {
152-
ActionOwner owner = ruleContext.getActionOwner(TEST_RUNNER_EXEC_GROUP);
153-
return owner == null ? ruleContext.getActionOwner() : owner;
154-
}
155-
156149
/**
157150
* Creates a test action and artifacts for the given rule. The test action will use the specified
158151
* executable and runfiles.
@@ -391,7 +384,7 @@ private TestParams createTestAction(int shards) throws InterruptedException {
391384
boolean splitCoveragePostProcessing = testConfiguration.splitCoveragePostProcessing();
392385
TestRunnerAction testRunnerAction =
393386
new TestRunnerAction(
394-
getOwner(),
387+
ruleContext.getActionOwner(),
395388
inputs,
396389
testRunfilesSupplier,
397390
testActionExecutable,

0 commit comments

Comments
 (0)