Fix error prone ComparisonOutOfRange in PersistentStringIndexer

hvadehra · copybara-github · commit cafa3cb1f275 · 2023-06-29T02:29:44.000-07:00
PiperOrigin-RevId: 544294153
Change-Id: Ia89d02a025dfafa213d68ea2110a79e5adccf79c
diff --git a/src/main/java/com/google/devtools/build/lib/actions/cache/PersistentStringIndexer.java b/src/main/java/com/google/devtools/build/lib/actions/cache/PersistentStringIndexer.java
@@ -65,7 +65,7 @@ public PersistentIndexMap(Path mapFile, Path journalFile, Clock clock) throws IO
     @Override
     protected boolean updateJournal() {
       long time = clock.nanoTime();
-      if (SAVE_INTERVAL_NS == 0 || time > nextUpdate) {
+      if (SAVE_INTERVAL_NS == 0L || time > nextUpdate) {
         nextUpdate = time + SAVE_INTERVAL_NS;
         return true;
       }

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ public PersistentIndexMap(Path mapFile, Path journalFile, Clock clock) throws IO`
`65`	`65`	`@Override`
`66`	`66`	`protected boolean updateJournal() {`
`67`	`67`	`long time = clock.nanoTime();`
`68`		`- if (SAVE_INTERVAL_NS == 0 \|\| time > nextUpdate) {`
	`68`	`+ if (SAVE_INTERVAL_NS == 0L \|\| time > nextUpdate) {`
`69`	`69`	`nextUpdate = time + SAVE_INTERVAL_NS;`
`70`	`70`	`return true;`
`71`	`71`	`}`