Skip to content

Commit bf320d2

Browse files
keertkcopybara-github
authored andcommitted
Fix relnotes script
- Update GitHub token retrieval - Allow checking out tags (final releases) in addition to branches (RCs) PiperOrigin-RevId: 534851155 Change-Id: I8b92898a8f5dd20139ca2467bb8604c6a8eabd67
1 parent 3f0b223 commit bf320d2

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

scripts/release/relnotes.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
"""Script to generate release notes."""
1616

17-
import os
1817
import re
1918
import subprocess
2019
import sys
@@ -87,13 +86,13 @@ def get_relnotes_between(base, head, is_major_release):
8786

8887
def get_label(issue_id):
8988
"""Get team-X label added to issue."""
90-
auth = os.system(
89+
auth = subprocess.check_output(
9190
"gsutil cat"
9291
" gs://bazel-trusted-encrypted-secrets/github-trusted-token.enc |"
9392
" gcloud kms decrypt --project bazel-public --location global"
9493
" --keyring buildkite --key github-trusted-token --ciphertext-file"
95-
" - --plaintext-file -"
96-
)
94+
" - --plaintext-file -", shell=True
95+
).decode("utf-8").strip().split("\n")[0]
9796
headers = {
9897
"Authorization": "Bearer " + auth,
9998
"Accept": "application/vnd.github+json",
@@ -159,11 +158,16 @@ def get_external_authors_between(base, head):
159158
# e.g. if current_release is 5.3.3, last_release should be 5.3.2 even if
160159
# latest release is 6.1.1
161160
current_release = git("rev-parse", "--abbrev-ref", "HEAD")[0]
162-
if not current_release.startswith("release-"):
163-
print("Error: Not a release- branch")
164-
sys.exit(1)
165161

166-
current_release = re.sub(r"rc\d", "", current_release[len("release-"):])
162+
if current_release.startswith("release-"):
163+
current_release = re.sub(r"rc\d", "", current_release[len("release-"):])
164+
else:
165+
try:
166+
current_release = git("describe", "--tags")[0]
167+
except Exception: # pylint: disable=broad-exception-caught
168+
print("Error: Not a release branch.")
169+
sys.exit(1)
170+
167171
is_major = bool(re.fullmatch(r"\d+.0.0", current_release))
168172

169173
tags = [tag for tag in git("tag", "--sort=refname") if "pre" not in tag]

0 commit comments

Comments
 (0)