Set neverlink inside java_common.merge

I've added 3 tests inside JavaStarlarkApiTest which check whether neverlink is propagated with:
  1. JavaInfo constructor
  2. java_common.compile
  3. java_common.merge

PiperOrigin-RevId: 483415276
Change-Id: I862c938f1ade5e9ccc9d740115cb02f65733e695

Author: kotlaja

src/main/java/com/google/devtools/build/lib/rules/java/BUILD

@@ -73,6 +73,7 @@ java_library(
         "//src/main/java/com/google/devtools/build/lib/vfs:pathfragment",
         "//src/main/java/net/starlark/java/eval",
         "//src/main/java/net/starlark/java/syntax",
+        "//third_party:error_prone_annotations",
         "//third_party:guava",
         "//third_party:jsr305",
     ],

src/main/java/com/google/devtools/build/lib/rules/java/JavaInfo.java

@@ -38,6 +38,7 @@
 import com.google.devtools.build.lib.starlarkbuildapi.FileApi;
 import com.google.devtools.build.lib.starlarkbuildapi.cpp.CcInfoApi;
 import com.google.devtools.build.lib.starlarkbuildapi.java.JavaInfoApi;
+import com.google.devtools.build.lib.starlarkbuildapi.java.JavaInfoApi.JavaInfoProviderApi;
 import com.google.devtools.build.lib.starlarkbuildapi.java.JavaModuleFlagsProviderApi;
 import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import java.util.ArrayList;
@@ -136,11 +137,13 @@ public static JavaInfo merge(
 
     NestedSetBuilder<Artifact> runtimeJars = NestedSetBuilder.stableOrder();
     NestedSetBuilder<String> javaConstraints = NestedSetBuilder.stableOrder();
+    boolean neverlink = false;
     for (JavaInfo javaInfo : providers) {
       if (mergeJavaOutputs) {
         runtimeJars.addAll(javaInfo.getDirectRuntimeJars());
       }
       javaConstraints.addAll(javaInfo.getJavaConstraints());
+      neverlink = neverlink || javaInfo.neverlink;
     }
 
     ImmutableList<JavaModuleFlagsProvider> javaModuleFlagsProviderProviders =
@@ -162,6 +165,7 @@ public static JavaInfo merge(
             // TODO(iirina): merge or remove JavaCompilationInfoProvider
             .setRuntimeJars(runtimeJars.build().toList())
             .setJavaConstraints(javaConstraints.build().toList())
+            .setNeverlink(neverlink)
             .addProvider(
                 JavaModuleFlagsProvider.class,
                 JavaModuleFlagsProvider.merge(javaModuleFlagsProviderProviders));

src/test/java/com/google/devtools/build/lib/rules/java/BUILD

@@ -168,7 +168,6 @@ java_test(
         "//src/main/java/com/google/devtools/build/lib/packages",
         "//src/main/java/com/google/devtools/build/lib/rules/cpp",
         "//src/main/java/com/google/devtools/build/lib/rules/java:java-compilation",
-        "//src/main/java/com/google/devtools/build/lib/rules/java:java-rules",
         "//src/main/java/com/google/devtools/build/lib/util:filetype",
         "//src/main/java/net/starlark/java/eval",
         "//src/test/java/com/google/devtools/build/lib/actions/util",

src/test/java/com/google/devtools/build/lib/rules/java/JavaStarlarkApiTest.java

@@ -2234,6 +2234,113 @@ public void javaCommonCompileNeverlink() throws Exception {
         .isEqualTo("plugin.jar libsomedep.jar");
   }
 
+  @Test
+  public void javaInfoConstructorWithNeverlink() throws Exception {
+    JavaToolchainTestUtil.writeBuildFileForJavaToolchain(scratch);
+    scratch.file(
+        "java/test/BUILD",
+        "load(':custom_rule.bzl', 'java_custom_library')",
+        "java_custom_library(name = 'somedep')");
+    scratch.file(
+        "java/test/custom_rule.bzl",
+        "def _impl(ctx):",
+        "  output_jar = ctx.actions.declare_file('lib' + ctx.label.name + '.jar')",
+        "  ctx.actions.write(output_jar, '')",
+        "  java_info = JavaInfo(",
+        "    output_jar = output_jar,",
+        "    compile_jar = None,",
+        "    neverlink = True,",
+        "  )",
+        "  return [",
+        "      java_info",
+        "  ]",
+        "java_custom_library = rule(",
+        "  implementation = _impl,",
+        "  fragments = ['java'],",
+        "  provides = [JavaInfo],",
+        ")");
+
+    ConfiguredTarget target = getConfiguredTarget("//java/test:somedep");
+
+    JavaInfo javaInfo = (JavaInfo) target.get(JavaInfo.PROVIDER.getKey());
+    assertThat(javaInfo.isNeverlink()).isTrue();
+  }
+
+  @Test
+  public void javaCommonMergeWithNeverlink() throws Exception {
+    JavaToolchainTestUtil.writeBuildFileForJavaToolchain(scratch);
+    scratch.file(
+        "java/test/BUILD",
+        "load(':custom_rule.bzl', 'java_custom_library')",
+        "java_custom_library(name = 'somedep')");
+    scratch.file(
+        "java/test/custom_rule.bzl",
+        "def _impl(ctx):",
+        "  output_jar = ctx.actions.declare_file('lib' + ctx.label.name + '.jar')",
+        "  ctx.actions.write(output_jar, '')",
+        "  java_info_with_neverlink = JavaInfo(",
+        "    output_jar = output_jar,",
+        "    compile_jar = None,",
+        "    neverlink = True,",
+        "  )",
+        "  java_info_without_neverlink = JavaInfo(",
+        "    output_jar = output_jar,",
+        "    compile_jar = None,",
+        "  )",
+        "  java_info = java_common.merge([java_info_with_neverlink, java_info_without_neverlink])",
+        "  return [",
+        "      java_info",
+        "  ]",
+        "java_custom_library = rule(",
+        "  implementation = _impl,",
+        "  fragments = ['java'],",
+        "  provides = [JavaInfo],",
+        ")");
+
+    ConfiguredTarget target = getConfiguredTarget("//java/test:somedep");
+
+    JavaInfo javaInfo = (JavaInfo) target.get(JavaInfo.PROVIDER.getKey());
+    assertThat(javaInfo.isNeverlink()).isTrue();
+  }
+
+  @Test
+  public void javaCommonCompileWithNeverlink() throws Exception {
+    JavaToolchainTestUtil.writeBuildFileForJavaToolchain(scratch);
+    scratch.file(
+        "java/test/BUILD",
+        "load(':custom_rule.bzl', 'java_custom_library')",
+        "java_custom_library(name = 'somedep',",
+        "    srcs = ['Dependency.java'])");
+    scratch.file(
+        "java/test/custom_rule.bzl",
+        "def _impl(ctx):",
+        "  output_jar = ctx.actions.declare_file('lib' + ctx.label.name + '.jar')",
+        "  java_info = java_common.compile(",
+        "    ctx,",
+        "    source_files = ctx.files.srcs,",
+        "    output = output_jar,",
+        "    java_toolchain = ctx.attr._java_toolchain[java_common.JavaToolchainInfo],",
+        "    neverlink = True,",
+        "  )",
+        "  return [",
+        "      java_info",
+        "  ]",
+        "java_custom_library = rule(",
+        "  implementation = _impl,",
+        "  attrs = {",
+        "    'srcs': attr.label_list(allow_files=['.java']),",
+        "    '_java_toolchain': attr.label(default = Label('//java/com/google/test:toolchain')),",
+        "  },",
+        "  fragments = ['java'],",
+        "  provides = [JavaInfo],",
+        ")");
+
+    ConfiguredTarget target = getConfiguredTarget("//java/test:somedep");
+
+    JavaInfo javaInfo = (JavaInfo) target.get(JavaInfo.PROVIDER.getKey());
+    assertThat(javaInfo.isNeverlink()).isTrue();
+  }
+
   /**
    * Tests that java_common.compile propagates native libraries from deps, runtime_deps, and
    * exports.