Skip to content

Commit b39a51c

Browse files
thiicopybara-github
authored andcommitted
Explicitly state that embedding macOS OpenJDK is for x86_64
This allows adding additional macOS OpenJDK that targets arm64 arch later. Closes #12620. PiperOrigin-RevId: 346138763
1 parent 033eaa8 commit b39a51c

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

WORKSPACE

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -394,21 +394,21 @@ http_file(
394394
)
395395

396396
http_file(
397-
name = "openjdk_macos",
397+
name = "openjdk_macos_x86_64",
398398
downloaded_file_path = "zulu-macos.tar.gz",
399399
sha256 = "8e283cfd23c7555be8e17295ed76eb8f00324c88ab904b8de37bbe08f90e569b",
400400
urls = ["https://mirror.bazel.build/openjdk/azul-zulu11.37.17-ca-jdk11.0.6/zulu11.37.17-ca-jdk11.0.6-macosx_x64-allmodules-b23d4e05466f2aa1fdcd72d3d3a8e962206b64bf-1581689066.tar.gz"],
401401
)
402402

403403
http_file(
404-
name = "openjdk_macos_vanilla",
404+
name = "openjdk_macos_x86_64_vanilla",
405405
downloaded_file_path = "zulu-macos-vanilla.tar.gz",
406406
sha256 = "e1fe56769f32e2aaac95e0a8f86b5a323da5af3a3b4bba73f3086391a6cc056f",
407407
urls = ["https://mirror.bazel.build/openjdk/azul-zulu11.37.17-ca-jdk11.0.6/zulu11.37.17-ca-jdk11.0.6-macosx_x64.tar.gz"],
408408
)
409409

410410
http_file(
411-
name = "openjdk_macos_minimal",
411+
name = "openjdk_macos_x86_64_minimal",
412412
downloaded_file_path = "zulu-macos-minimal.tar.gz",
413413
sha256 = "1bacb1c07035d4066d79f0b65b4ea0ebd1954f3662bdfe3618da382ac8fd23a6",
414414
urls = ["https://mirror.bazel.build/openjdk/azul-zulu11.37.17-ca-jdk11.0.6/zulu11.37.17-ca-jdk11.0.6-macosx_x64-minimal-b23d4e05466f2aa1fdcd72d3d3a8e962206b64bf-1581689063.tar.gz"],

src/BUILD

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ rule_size_test(
175175
filegroup(
176176
name = "embedded_jdk_allmodules_cached",
177177
srcs = select({
178-
"//src/conditions:darwin": [
179-
"@openjdk_macos//file",
178+
"//src/conditions:darwin_x86_64": [
179+
"@openjdk_macos_x86_64//file",
180180
],
181181
"//src/conditions:windows": [
182182
"@openjdk_win//file",
@@ -194,8 +194,8 @@ filegroup(
194194
filegroup(
195195
name = "embedded_jdk_minimal_cached",
196196
srcs = select({
197-
"//src/conditions:darwin": [
198-
"@openjdk_macos_minimal//file",
197+
"//src/conditions:darwin_x86_64": [
198+
"@openjdk_macos_x86_64_minimal//file",
199199
],
200200
"//src/conditions:windows": [
201201
"@openjdk_win_minimal//file",
@@ -213,8 +213,8 @@ filegroup(
213213
filegroup(
214214
name = "embedded_jdk_vanilla",
215215
srcs = select({
216-
"//src/conditions:darwin": [
217-
"@openjdk_macos_vanilla//file",
216+
"//src/conditions:darwin_x86_64": [
217+
"@openjdk_macos_x86_64_vanilla//file",
218218
],
219219
"//src/conditions:windows": [
220220
"@openjdk_win_vanilla//file",
@@ -709,7 +709,7 @@ filegroup(
709709
"@openjdk15_windows_archive//:WORKSPACE",
710710
"@openjdk_linux_aarch64_minimal//file",
711711
"@openjdk_linux_minimal//file",
712-
"@openjdk_macos_minimal//file",
712+
"@openjdk_macos_x86_64_minimal//file",
713713
"@openjdk_win_minimal//file",
714714
"@remote_coverage_tools_for_testing//:WORKSPACE",
715715
"@remote_java_tools_darwin_for_testing//:WORKSPACE",

src/test/shell/testenv.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ EOF
294294
"openjdk15_windows_archive"
295295
"openjdk_linux_aarch64_minimal"
296296
"openjdk_linux_minimal"
297-
"openjdk_macos_minimal"
297+
"openjdk_macos_x86_64_minimal"
298298
"openjdk_win_minimal"
299299
"remote_coverage_tools_for_testing"
300300
"remote_java_tools_for_testing"

0 commit comments

Comments
 (0)