Skip to content

Commit 9b30172

Browse files
scelemeteorcloudy
authored andcommitted
[3/3] Bump grpc to 1.33.1 to fix corruption when downloading CAS blobs
Part 3: remove 1.32.x from third_party/grpc. grpc-java versions 1.27 through 1.32 had a bug where messages could arrive after the call was reported clsoed. In the case of bazel, this meant that in GrpcCacheClient, onNext could be called after onError. This leads to offset bookkeeping getting out of sync, and corrupts the CAS blob download. #12927 Closes: #13106
1 parent 1c900bf commit 9b30172

10 files changed

+1
-123
lines changed

third_party/grpc/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ load("//tools/distributions:distribution_rules.bzl", "distrib_java_import", "dis
1818

1919
licenses(["notice"]) # Apache v2
2020

21-
exports_files(["grpc_1.32.0.patch", "grpc_1.33.1.patch"])
21+
exports_files(["grpc_1.33.1.patch"])
2222

2323
package(default_visibility = ["//visibility:public"])
2424

third_party/grpc/grpc-api-1.32.2.jar

-223 KB
Binary file not shown.

third_party/grpc/grpc-auth-1.32.2.jar

-14.2 KB
Binary file not shown.
-29.9 KB
Binary file not shown.

third_party/grpc/grpc-core-1.32.2.jar

-620 KB
Binary file not shown.
-237 KB
Binary file not shown.
-5.06 KB
Binary file not shown.
-7.45 KB
Binary file not shown.

third_party/grpc/grpc-stub-1.32.2.jar

-48.4 KB
Binary file not shown.

third_party/grpc/grpc_1.32.0.patch

Lines changed: 0 additions & 122 deletions
This file was deleted.

0 commit comments

Comments
 (0)