Skip to content

Commit 8e56b94

Browse files
thiiphilwo
authored andcommitted
Explicitly state that embedding macOS OpenJDK is for x86_64
This allows adding additional macOS OpenJDK that targets arm64 arch later. Closes #12620. PiperOrigin-RevId: 346138763
1 parent 270f00d commit 8e56b94

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

WORKSPACE

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -389,21 +389,21 @@ http_file(
389389
)
390390

391391
http_file(
392-
name = "openjdk_macos",
392+
name = "openjdk_macos_x86_64",
393393
downloaded_file_path = "zulu-macos.tar.gz",
394394
sha256 = "8e283cfd23c7555be8e17295ed76eb8f00324c88ab904b8de37bbe08f90e569b",
395395
urls = ["https://mirror.bazel.build/openjdk/azul-zulu11.37.17-ca-jdk11.0.6/zulu11.37.17-ca-jdk11.0.6-macosx_x64-allmodules-b23d4e05466f2aa1fdcd72d3d3a8e962206b64bf-1581689066.tar.gz"],
396396
)
397397

398398
http_file(
399-
name = "openjdk_macos_vanilla",
399+
name = "openjdk_macos_x86_64_vanilla",
400400
downloaded_file_path = "zulu-macos-vanilla.tar.gz",
401401
sha256 = "e1fe56769f32e2aaac95e0a8f86b5a323da5af3a3b4bba73f3086391a6cc056f",
402402
urls = ["https://mirror.bazel.build/openjdk/azul-zulu11.37.17-ca-jdk11.0.6/zulu11.37.17-ca-jdk11.0.6-macosx_x64.tar.gz"],
403403
)
404404

405405
http_file(
406-
name = "openjdk_macos_minimal",
406+
name = "openjdk_macos_x86_64_minimal",
407407
downloaded_file_path = "zulu-macos-minimal.tar.gz",
408408
sha256 = "1bacb1c07035d4066d79f0b65b4ea0ebd1954f3662bdfe3618da382ac8fd23a6",
409409
urls = ["https://mirror.bazel.build/openjdk/azul-zulu11.37.17-ca-jdk11.0.6/zulu11.37.17-ca-jdk11.0.6-macosx_x64-minimal-b23d4e05466f2aa1fdcd72d3d3a8e962206b64bf-1581689063.tar.gz"],

src/BUILD

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@ rule_size_test(
176176
filegroup(
177177
name = "embedded_jdk_allmodules_cached",
178178
srcs = select({
179-
"//src/conditions:darwin": [
180-
"@openjdk_macos//file",
179+
"//src/conditions:darwin_x86_64": [
180+
"@openjdk_macos_x86_64//file",
181181
],
182182
"//src/conditions:darwin_arm64": [
183183
"@openjdk_macos_aarch64//file",
@@ -198,8 +198,8 @@ filegroup(
198198
filegroup(
199199
name = "embedded_jdk_minimal_cached",
200200
srcs = select({
201-
"//src/conditions:darwin": [
202-
"@openjdk_macos_minimal//file",
201+
"//src/conditions:darwin_x86_64": [
202+
"@openjdk_macos_x86_64_minimal//file",
203203
],
204204
"//src/conditions:darwin_arm64": [
205205
"@openjdk_macos_aarch64_minimal//file",
@@ -220,8 +220,8 @@ filegroup(
220220
filegroup(
221221
name = "embedded_jdk_vanilla",
222222
srcs = select({
223-
"//src/conditions:darwin": [
224-
"@openjdk_macos_vanilla//file",
223+
"//src/conditions:darwin_x86_64": [
224+
"@openjdk_macos_x86_64_vanilla//file",
225225
],
226226
"//src/conditions:darwin_arm64": [
227227
"@openjdk_macos_aarch64_vanilla//file",
@@ -772,7 +772,7 @@ filegroup(
772772
"@openjdk15_windows_archive//:WORKSPACE",
773773
"@openjdk_linux_aarch64_minimal//file",
774774
"@openjdk_linux_minimal//file",
775-
"@openjdk_macos_minimal//file",
775+
"@openjdk_macos_x86_64_minimal//file",
776776
"@openjdk_macos_aarch64_minimal//file",
777777
"@openjdk_win_minimal//file",
778778
"@remote_coverage_tools_for_testing//:WORKSPACE",

src/test/shell/testenv.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ EOF
296296
"openjdk15_windows_archive"
297297
"openjdk_linux_aarch64_minimal"
298298
"openjdk_linux_minimal"
299-
"openjdk_macos_minimal"
299+
"openjdk_macos_x86_64_minimal"
300300
"openjdk_macos_aarch64_minimal"
301301
"openjdk_win_minimal"
302302
"remote_coverage_tools_for_testing"

0 commit comments

Comments
 (0)