Skip to content

Commit 5ab5d80

Browse files
rickeylevcopybara-github
authored andcommitted
python: Remove mention of defunct --python_binary flag
This flag has been removed from the Google build, so don't mention it in the comment as a concern. PiperOrigin-RevId: 523510796 Change-Id: I4622296895b099ec02bc04adae9ebcdf6b036910
1 parent b77e8c2 commit 5ab5d80

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

src/main/starlark/builtins_bzl/common/python/py_executable.bzl

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -214,19 +214,13 @@ def _get_runtime_details(ctx, semantics):
214214
A struct; see inline-field comments of the return value for details.
215215
"""
216216

217-
# NOTE: Both Bazel and Google have similar legacy "path to a python
218-
# interpreter" flags with similar functions, but with subtle differences.
219-
#
220217
# Bazel has --python_path. This flag has a computed default of "python" when
221218
# its actual default is null (see
222219
# BazelPythonConfiguration.java#getPythonPath). This flag is only used if
223-
# toolchains are not enabled and `--python_top` isn't set.
224-
#
225-
# Google has --python_binary. This flag defaults to null; no special
226-
# computed behavior. If set, it is used instead of any runtime or toolchain.
227-
# This is a legacy behavior, but not fully cleaned up yet.
220+
# toolchains are not enabled and `--python_top` isn't set. Note that Google
221+
# used to have a variant of this named --python_binary, but it has since
222+
# been removed.
228223
#
229-
# TODO(b/230428071): Remove this once Google's --python_binary flag is removed.
230224
# TOOD(bazelbuild/bazel#7901): Remove this once --python_path flag is removed.
231225

232226
if IS_BAZEL:

0 commit comments

Comments
 (0)