Skip to content

Commit 496d3de

Browse files
aj-michaelvladmos
authored andcommitted
Automated g4 rollback of commit bcd2355.
*** Reason for rollback *** RELNOTES: None PiperOrigin-RevId: 154315543
1 parent 3d4db19 commit 496d3de

File tree

2 files changed

+1
-25
lines changed

2 files changed

+1
-25
lines changed

src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ static CustomCommandLine createCommandLineFromToolchains(
586586
}
587587

588588
for (Artifact src : protosToCompile) {
589-
cmdLine.addPath(src.getExecPath());
589+
cmdLine.addPath(src.getRootRelativePath());
590590
}
591591

592592
if (!allowServices) {

src/test/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilderTest.java

-24
Original file line numberDiff line numberDiff line change
@@ -105,30 +105,6 @@ public void commandLine_basic() throws Exception {
105105
.inOrder();
106106
}
107107

108-
@Test
109-
public void commandline_derivedArtifact() {
110-
// Verify that the command line contains the correct path to a generated protocol buffers.
111-
SupportData supportData =
112-
SupportData.create(
113-
Predicates.<TransitiveInfoCollection>alwaysFalse(),
114-
ImmutableList.of(derivedArtifact("//:dont-care", "source_file.proto")),
115-
NestedSetBuilder.<Artifact>emptySet(STABLE_ORDER) /* protosInDirectDeps */,
116-
NestedSetBuilder.<Artifact>emptySet(STABLE_ORDER) /* transitiveImports */,
117-
true /* hasProtoSources */);
118-
119-
CustomCommandLine cmdLine =
120-
createCommandLineFromToolchains(
121-
ImmutableList.<ToolchainInvocation>of() /* toolchainInvocations */,
122-
supportData.getDirectProtoSources(),
123-
supportData.getTransitiveImports(),
124-
null /* protosInDirectDeps */,
125-
"//foo:bar",
126-
true /* allowServices */,
127-
ImmutableList.<String>of() /* protocOpts */);
128-
129-
assertThat(cmdLine.arguments()).containsExactly("out/source_file.proto");
130-
}
131-
132108
@Test
133109
public void commandLine_strictDeps() throws Exception {
134110
ProtoLangToolchainProvider toolchain =

0 commit comments

Comments
 (0)