Skip to content

Commit 47edc57

Browse files
keithcopybara-github
authored andcommitted
Silence swiftmodule timestamp warnings
As part of #13091 dsymtuil started producing these warnings: ``` warning: Timestamp mismatch for bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-7786d55448f4/bin/Modules/DependencyInjection/DependencyInjection.swiftmodule: 2021-03-05 13:54:33.542331246 and 1969-12-31 16:00:00.000000000 ``` In general we're happily ignoring this to get hermetic outputs instead (it's being compared against the file modification timestamp) This change disables this warning. It appears this feature has been around for at least 3 years swiftlang/llvm-project@2dd9848 so we should be good for all the versions of Xcode we support. Relevant logic: https://github.com/apple/llvm-project/blob/902bb11a46eb82e81d7e8b34450481e143a208b2/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp#L407-L421 Closes #13165. PiperOrigin-RevId: 366215825
1 parent 0299cd7 commit 47edc57

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

tools/osx/crosstool/wrapped_clang.cc

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,13 @@ int main(int argc, char *argv[]) {
405405
return 0;
406406
}
407407

408-
std::vector<std::string> dsymutil_args = {
409-
"/usr/bin/xcrun", "dsymutil", linked_binary, "-o", dsym_path, "--flat"};
408+
std::vector<std::string> dsymutil_args = {"/usr/bin/xcrun",
409+
"dsymutil",
410+
linked_binary,
411+
"-o",
412+
dsym_path,
413+
"--flat",
414+
"--no-swiftmodule-timestamp"};
410415
RunSubProcess(dsymutil_args);
411416
return 0;
412417
}

0 commit comments

Comments
 (0)