Skip to content

Commit 2ddacab

Browse files
michaeledgarcopybara-github
authored andcommitted
Add start/end timestamps to ActionExecuted event protobuf.
Also adds a repeated `Any` field for strategies to report strategy-specific execution details. First commit addressing issue #19471. PiperOrigin-RevId: 573896902 Change-Id: I3d58cdfb503d552999c6261fc7fbd04c7d1de835
1 parent 14e3d1b commit 2ddacab

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/main/java/com/google/devtools/build/lib/buildeventstream/proto/BUILD

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
load("@rules_java//java:defs.bzl", "java_proto_library")
2-
load("//tools/build_rules:utilities.bzl", "java_library_srcs")
32
load("@rules_proto//proto:defs.bzl", "proto_library")
3+
load("//tools/build_rules:utilities.bzl", "java_library_srcs")
44

55
package(default_visibility = ["//src:__subpackages__"])
66

@@ -31,6 +31,7 @@ proto_library(
3131
"//src/main/protobuf:command_line_proto",
3232
"//src/main/protobuf:failure_details_proto",
3333
"//src/main/protobuf:invocation_policy_proto",
34+
"@com_google_protobuf//:any_proto",
3435
"@com_google_protobuf//:duration_proto",
3536
"@com_google_protobuf//:timestamp_proto",
3637
],

src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ syntax = "proto3";
1818

1919
package build_event_stream;
2020

21+
import "google/protobuf/any.proto";
2122
import "google/protobuf/duration.proto";
2223
import "google/protobuf/timestamp.proto";
2324
import "src/main/java/com/google/devtools/build/lib/packages/metrics/package_load_metrics.proto";
@@ -577,6 +578,15 @@ message ActionExecuted {
577578

578579
// Only populated if success = false, and sometimes not even then.
579580
failure_details.FailureDetail failure_detail = 11;
581+
582+
// Start of action execution, before any attempted execution begins.
583+
google.protobuf.Timestamp start_time = 12;
584+
585+
// End of action execution, after all attempted execution completes.
586+
google.protobuf.Timestamp end_time = 13;
587+
588+
// Additional details about action execution supplied by any/all strategies.
589+
repeated google.protobuf.Any strategy_details = 14;
580590
}
581591

582592
// Collection of all output files belonging to that output group.

0 commit comments

Comments
 (0)