Skip to content

Commit 15e691d

Browse files
larsrc-googlecopybara-github
authored andcommitted
Start using the experimental_worker_multiplex flag.
RELNOTES: Puts the experimental_worker_multiplex flag to use. PiperOrigin-RevId: 327794094
1 parent adc845e commit 15e691d

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

src/main/java/com/google/devtools/build/lib/worker/WorkerModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,12 +154,14 @@ public void registerSpawnStrategies(
154154
SpawnStrategyRegistry.Builder registryBuilder, CommandEnvironment env) {
155155
Preconditions.checkNotNull(workerPool);
156156
SandboxOptions sandboxOptions = env.getOptions().getOptions(SandboxOptions.class);
157+
options = env.getOptions().getOptions(WorkerOptions.class);
157158
LocalEnvProvider localEnvProvider = LocalEnvProvider.forCurrentOs(env.getClientEnv());
158159
WorkerSpawnRunner spawnRunner =
159160
new WorkerSpawnRunner(
160161
new SandboxHelpers(sandboxOptions.delayVirtualInputMaterialization),
161162
env.getExecRoot(),
162163
workerPool,
164+
options.workerMultiplex,
163165
env.getReporter(),
164166
createFallbackRunner(env, localEnvProvider),
165167
localEnvProvider,

src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ final class WorkerSpawnRunner implements SpawnRunner {
8484
private final SandboxHelpers helpers;
8585
private final Path execRoot;
8686
private final WorkerPool workers;
87+
private final boolean multiplex;
8788
private final ExtendedEventHandler reporter;
8889
private final SpawnRunner fallbackRunner;
8990
private final LocalEnvProvider localEnvProvider;
@@ -96,6 +97,7 @@ public WorkerSpawnRunner(
9697
SandboxHelpers helpers,
9798
Path execRoot,
9899
WorkerPool workers,
100+
boolean multiplex,
99101
ExtendedEventHandler reporter,
100102
SpawnRunner fallbackRunner,
101103
LocalEnvProvider localEnvProvider,
@@ -106,6 +108,7 @@ public WorkerSpawnRunner(
106108
this.helpers = helpers;
107109
this.execRoot = execRoot;
108110
this.workers = Preconditions.checkNotNull(workers);
111+
this.multiplex = multiplex;
109112
this.reporter = reporter;
110113
this.fallbackRunner = fallbackRunner;
111114
this.localEnvProvider = localEnvProvider;
@@ -211,7 +214,7 @@ private SpawnResult actuallyExec(Spawn spawn, SpawnExecutionContext context)
211214
workerFilesCombinedHash,
212215
workerFiles,
213216
context.speculating(),
214-
Spawns.supportsMultiplexWorkers(spawn),
217+
multiplex && Spawns.supportsMultiplexWorkers(spawn),
215218
protocolFormat);
216219

217220
SpawnMetrics.Builder spawnMetrics =

src/test/shell/integration/bazel_worker_multiplexer_test.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ add_to_bazelrc "build -s"
3636
add_to_bazelrc "build --spawn_strategy=worker,standalone"
3737
add_to_bazelrc "build --worker_verbose --worker_max_instances=3"
3838
add_to_bazelrc "build --debug_print_action_contexts"
39+
add_to_bazelrc "build --experimental_worker_multiplex"
3940
add_to_bazelrc "build ${ADDITIONAL_BUILD_FLAGS}"
4041

4142
function set_up() {

0 commit comments

Comments
 (0)