Remove deprecated from builtins

Author: dzbarsky

extras/gomock.bzl

@@ -32,7 +32,7 @@ _MOCKGEN_TOOL = Label("//extras/gomock:mockgen")
 _MOCKGEN_MODEL_LIB = Label("//extras/gomock:mockgen_model")
 
 def _gomock_source_impl(ctx):
-    go_ctx = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
 
     # In Source mode, it's not necessary to pass through a library, as the only thing we use it for is setting up
     # the relative file locations. Forcing users to pass a library makes it difficult in the case where a mock should
@@ -73,7 +73,7 @@ def _gomock_source_impl(ctx):
             needed_files.append(aux)
         args += ["-aux_files", ",".join(aux_files)]
 
-    sdk = go_ctx.sdk
+    sdk = go.sdk
 
     inputs_direct = needed_files + [source]
     inputs_transitive = [sdk.tools, sdk.headers, sdk.srcs]

go/private/rules/binary.bzl

@@ -96,7 +96,7 @@ def new_cc_import(
 
 def _go_binary_impl(ctx):
     """go_binary_impl emits actions for compiling and linking a go executable."""
-    go = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
 
     is_main = go.mode.link not in (LINKMODE_SHARED, LINKMODE_PLUGIN)
     library = go.new_library(go, importable = False, is_main = is_main)

go/private/rules/library.bzl

@@ -34,7 +34,7 @@ load(
 
 def _go_library_impl(ctx):
     """Implements the go_library() rule."""
-    go = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
     library = go.new_library(go)
     source = go.library_to_source(go, ctx.attr, library, ctx.coverage_instrumented())
     archive = go.archive(go, source)

go/private/rules/nogo.bzl

@@ -38,7 +38,7 @@ def _nogo_impl(ctx):
         return None
 
     # Generate the source for the nogo binary.
-    go = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
     nogo_main = go.declare_file(go, path = "nogo_main.go")
     nogo_args = ctx.actions.args()
     nogo_args.add("gennogomain")

go/private/rules/source.bzl

@@ -27,7 +27,7 @@ load(
 
 def _go_source_impl(ctx):
     """Implements the go_source() rule."""
-    go = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
     library = go.new_library(go)
     source = go.library_to_source(go, ctx.attr, library, ctx.coverage_instrumented())
     return [

go/private/rules/stdlib.bzl

@@ -30,7 +30,7 @@ load(
 )
 
 def _stdlib_impl(ctx):
-    go = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
     return go.toolchain.actions.stdlib(go)
 
 stdlib = rule(

go/private/rules/test.bzl

@@ -56,7 +56,7 @@ def _go_test_impl(ctx):
     It emits an action to run the test generator, and then compiles the
     test into a binary."""
 
-    go = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
 
     # Compile the library to test with internal white box tests
     internal_library = go.new_library(go, testfilter = "exclude")

proto/compiler.bzl

@@ -182,7 +182,7 @@ def proto_path(src, proto):
     return src.path[len(prefix):]
 
 def _go_proto_compiler_impl(ctx):
-    go = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
     library = go.new_library(go)
     source = go.library_to_source(go, ctx.attr, library, ctx.coverage_instrumented())
     proto_toolchain = proto_toolchains.find_toolchain(

proto/def.bzl

@@ -67,7 +67,7 @@ def get_imports(attr, importpath):
     return depset(direct = direct.keys(), transitive = transitive)
 
 def _go_proto_aspect_impl(_target, ctx):
-    go = go_context(ctx, ctx.rule.attr)
+    go = go_context(ctx, ctx.rule.attr, include_deprecated_properties = False)
     imports = get_imports(ctx.rule.attr, go.importpath)
     return [GoProtoImports(imports = imports)]
 
@@ -90,7 +90,7 @@ def _proto_library_to_source(_go, attr, source, merge):
             merge(source, compiler[GoSource])
 
 def _go_proto_library_impl(ctx):
-    go = go_context(ctx)
+    go = go_context(ctx, include_deprecated_properties = False)
     if ctx.attr.compiler:
         #TODO: print("DEPRECATED: compiler attribute on {}, use compilers instead".format(ctx.label))
         compilers = [ctx.attr.compiler]