Skip to content

Commit 7bc3905

Browse files
rahulbawanerahulbawane
authored
Develop (#73)
1 parent ad294e9 commit 7bc3905

File tree

14 files changed

+322
-110
lines changed

14 files changed

+322
-110
lines changed

‎BVSwift.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
Pod::Spec.new do |s|
1010
s.name = 'BVSwift'
11-
s.version = '1.15.3'
11+
s.version = '1.16.0'
1212
s.summary = 'Simple Swift based iOS SDK to interact with the Bazaarvoice platform API.'
1313
s.description = 'The Bazaarvoice Software Development Kit (SDK) is a Swift iOS library that provides an easy way to generate REST calls to the Bazaarvoice Developer API. Using this SDK, mobile developers can quickly integrate Bazaarvoice content into their native iOS apps for iPhone and iPad on iOS 8.0 or newer.'
1414

‎BVSwift/BVCommon/Configuration/BVConstants.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ internal struct BVConstants {
1818
static let appVersionField: String = "_appVersion"
1919
static let buildNumberField: String = "_buildNumber"
2020
static let sdkVersionField: String = "_bvIosSwiftSdkVersion"
21-
static let bvSwiftSDKVersion: String = "1.15.3"
21+
static let bvSwiftSDKVersion: String = "1.16.0"
2222
}
2323

2424
internal extension Bundle {

‎BVSwift/Support/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>FMWK</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>1.15.3</string>
20+
<string>1.16.0</string>
2121
<key>CFBundleVersion</key>
2222
<string>1</string>
2323
<key>NSPrincipalClass</key>

‎BVSwiftTests/BVConversations/Submission/BVReviewSubmissionTest.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,10 @@ class BVReviewSubmissionTest: XCTestCase {
153153
}
154154
}
155155

156-
func testPreviewReviewWithVideo() {
156+
func testPreviewReviewWithYoutubeVideo() {
157157

158158
let expectation =
159-
self.expectation(description: "testPreviewReviewWithVideo")
159+
self.expectation(description: "testPreviewReviewWithYoutubeVideo")
160160

161161
guard let reviewSubmission = fillOutReview(.preview) else {
162162
XCTFail()

‎Examples/BVSwiftDemo/BVSwiftDemo.xcodeproj/project.pbxproj

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
archiveVersion = 1;
44
classes = {
55
};
6-
objectVersion = 51;
6+
objectVersion = 54;
77
objects = {
88

99
/* Begin PBXBuildFile section */
@@ -79,6 +79,7 @@
7979
9FF7EB972473C2B0007FD337 /* Coordinator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9FF7EB962473C2B0007FD337 /* Coordinator.swift */; };
8080
9FF7EB992473C346007FD337 /* AppCoordinator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9FF7EB982473C346007FD337 /* AppCoordinator.swift */; };
8181
9FF7EB9D2473DA11007FD337 /* Storyboarded.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9FF7EB9C2473DA11007FD337 /* Storyboarded.swift */; };
82+
B7794A322DC0A986009B6D4E /* conversationsReviewSummary.json in Resources */ = {isa = PBXBuildFile; fileRef = B7794A312DC0A986009B6D4E /* conversationsReviewSummary.json */; };
8283
/* End PBXBuildFile section */
8384

8485
/* Begin PBXFileReference section */
@@ -160,6 +161,7 @@
160161
9FF7EB982473C346007FD337 /* AppCoordinator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppCoordinator.swift; sourceTree = "<group>"; };
161162
9FF7EB9C2473DA11007FD337 /* Storyboarded.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Storyboarded.swift; sourceTree = "<group>"; };
162163
A417D650407251B9FF79AE8A /* Pods_BVSwiftDemo.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_BVSwiftDemo.framework; sourceTree = BUILT_PRODUCTS_DIR; };
164+
B7794A312DC0A986009B6D4E /* conversationsReviewSummary.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = conversationsReviewSummary.json; sourceTree = "<group>"; };
163165
/* End PBXFileReference section */
164166

165167
/* Begin PBXFrameworksBuildPhase section */
@@ -264,6 +266,7 @@
264266
children = (
265267
42CE5FA724ADE2B3009D050B /* conversationsAuthorWithIncludes.json */,
266268
42CE5FA624ADE2B3009D050B /* conversationsProductsIncludeStats.json */,
269+
B7794A312DC0A986009B6D4E /* conversationsReviewSummary.json */,
267270
42CE5FAC24ADE2B3009D050B /* conversationsQuestionsIncludeAnswers.json */,
268271
42CE5FAB24ADE2B3009D050B /* conversationsReviewsEnduranceCycles.json */,
269272
42CE5FB024ADE2B4009D050B /* curationsEnduranceCycles.json */,
@@ -498,6 +501,7 @@
498501
42CE5FC524AE19F1009D050B /* reviewHighlights.json in Resources */,
499502
42BC267824C9653B000CA351 /* BVSwiftDemoActionCell.xib in Resources */,
500503
42CE5FB624ADE2B4009D050B /* conversationsAuthorWithIncludes.json in Resources */,
504+
B7794A322DC0A986009B6D4E /* conversationsReviewSummary.json in Resources */,
501505
42CE5FBD24ADE2B4009D050B /* userProfile1.json in Resources */,
502506
42CE5FC324ADE2B4009D050B /* submitQuestion.json in Resources */,
503507
42BC40EC2473BB5100008434 /* Assets.xcassets in Resources */,
@@ -687,6 +691,8 @@
687691
buildSettings = {
688692
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
689693
CODE_SIGN_STYLE = Automatic;
694+
DEVELOPMENT_TEAM = "";
695+
EXCLUDED_ARCHS = arm64;
690696
INFOPLIST_FILE = BVSwiftDemo/Info.plist;
691697
IPHONEOS_DEPLOYMENT_TARGET = 13.2;
692698
LD_RUNPATH_SEARCH_PATHS = (
@@ -763,6 +769,8 @@
763769
buildSettings = {
764770
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
765771
CODE_SIGN_STYLE = Automatic;
772+
DEVELOPMENT_TEAM = "";
773+
EXCLUDED_ARCHS = "";
766774
INFOPLIST_FILE = BVSwiftDemo/Info.plist;
767775
IPHONEOS_DEPLOYMENT_TARGET = 13.2;
768776
LD_RUNPATH_SEARCH_PATHS = (
@@ -900,6 +908,8 @@
900908
buildSettings = {
901909
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
902910
CODE_SIGN_STYLE = Automatic;
911+
DEVELOPMENT_TEAM = "";
912+
EXCLUDED_ARCHS = "";
903913
INFOPLIST_FILE = BVSwiftDemo/Info.plist;
904914
IPHONEOS_DEPLOYMENT_TARGET = 13.2;
905915
LD_RUNPATH_SEARCH_PATHS = (
@@ -921,6 +931,7 @@
921931
buildSettings = {
922932
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
923933
CODE_SIGN_STYLE = Automatic;
934+
DEVELOPMENT_TEAM = "";
924935
INFOPLIST_FILE = BVSwiftDemo/Info.plist;
925936
IPHONEOS_DEPLOYMENT_TARGET = 13.2;
926937
LD_RUNPATH_SEARCH_PATHS = (

‎Examples/BVSwiftDemo/BVSwiftDemo/Manager/MockDataManager.swift

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,14 @@ class MockDataManager {
4444
let containsConversationsQuestions = url.contains(URLConstants.conversationsQuestionsMatch)
4545
let containsConversationsProducts = url.contains(URLConstants.conversationsProductMatch)
4646
let containsConversationsAuthors = url.contains(URLConstants.conversationsAuthorsMatch)
47+
let containsConversationsReviewSummary = url.contains(URLConstants.conversationsReviewSummary)
4748
let containsSubmitReviews = url.contains(URLConstants.submitReviewMatch)
4849
let containsSubmitPhotoReviews = url.contains(URLConstants.submitReviewPhotoMatch)
4950
let containsSubmitQuestion = url.contains(URLConstants.submitQuestionMatch)
5051
let containsSubmitAnswers = url.contains(URLConstants.submitAnswerMatch)
5152
let containsPINRequest = url.contains(URLConstants.pinRequestMatch)
5253

53-
return containsCurations || containsCurationsPhotoPost || containsRecommendations || containsProfile || containsConversationsReviews || containsConversationsQuestions || containsConversationsProducts || containsConversationsAuthors || containsSubmitReviews || containsSubmitPhotoReviews || containsSubmitQuestion || containsSubmitAnswers || containsPINRequest || containsConversationsReviewHighlights
54+
return containsCurations || containsCurationsPhotoPost || containsRecommendations || containsProfile || containsConversationsReviews || containsConversationsQuestions || containsConversationsProducts || containsConversationsReviewSummary || containsConversationsAuthors || containsSubmitReviews || containsSubmitPhotoReviews || containsSubmitQuestion || containsSubmitAnswers || containsPINRequest || containsConversationsReviewHighlights
5455

5556
}
5657

@@ -92,6 +93,15 @@ class MockDataManager {
9293
)
9394
}
9495

96+
if url.contains(URLConstants.conversationsReviewSummary) {
97+
98+
return HTTPStubsResponse(
99+
fileAtPath: OHPathForFile("conversationsReviewSummary.json", type(of: self))!,
100+
statusCode: 200,
101+
headers: Headers.header
102+
)
103+
}
104+
95105
if url.contains(URLConstants.conversationsMatchReview) {
96106

97107
// Conversations requests will vary depending on parameters

‎Examples/BVSwiftDemo/BVSwiftDemo/Resources/JSONFiles/conversationsReviewSummary.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"summary": "This moisturizer provides a natural, radiant glow and a lightweight, comfortable texture. It contains nourishing ingredients that deeply moisturize the skin, giving a refreshing and cooling sensation upon application. The moisturizer effectively seals in moisture, preventing water loss throughout the day, and helps to even out skin tone and minimize the appearance of imperfections. It absorbs quickly, allowing for immediate makeup application, and leaves the skin feeling smooth, soft, and hydrated without any greasy residue. The moisturizer is suitable for all skin types, including sensitive skin, and provides a subtle brightening effect, giving the skin a youthful appearance. Overall, this moisturizer is a great option for achieving a healthy, glowing complexion.",
3+
"status": 200,
4+
"type": "TEXT",
5+
"title": "REVIEW_SUMMARY",
6+
"detail": "PARAGRAPH_SUMMARY",
7+
"disclaimer": "This summary is generated by artificial intelligence based on customer reviews"
8+
}

‎Examples/BVSwiftDemo/BVSwiftDemo/Resources/URLConstants.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,13 @@ class URLConstants {
2020
static let conversationsProductMatch = "bazaarvoice.com/data/products"
2121
static let conversationsAuthorsMatch = "bazaarvoice.com/data/authors"
2222
static let conversationsReviewHighlightsMatch = "bazaarvoice.com/highlights"
23+
static let conversationsReviewSummary = "bazaarvoice.com/data/reviewsummary"
2324
static let submitReviewMatch = "bazaarvoice.com/data/submitreview"
2425
static let submitReviewPhotoMatch = "bazaarvoice.com/data/uploadphoto"
2526
static let submitQuestionMatch = "bazaarvoice.com/data/submitquestion"
2627
static let submitAnswerMatch = "bazaarvoice.com/data/submitanswer"
2728
static let pinRequestMatch = "bazaarvoice.com/pin/toreview"
28-
29+
2930
}
3031

3132
class User {

0 commit comments

Comments
 (0)