Skip to content

Commit 63c7c02

Browse files
committed
chore: add build annotation
1 parent a0d4056 commit 63c7c02

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

QtScrcpy/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ if (MSVC)
5555

5656
# avoid warning C4819
5757
#add_compile_options(-source-charset:utf-8)
58-
#add_compile_options(/utf-8)
58+
# /utf-8 will set source charset and execution charset to utf-8, so we don't need to set source-charset:utf-8
59+
add_compile_options(/utf-8)
5960

6061
# ensure we use minimal "windows.h" lib without the crazy min max macros
6162
add_compile_definitions(NOMINMAX WIN32_LEAN_AND_MEAN)
@@ -264,6 +265,7 @@ endif()
264265

265266
# MacOS
266267
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
268+
# qt6 need 10.15 or later
267269
set(CMAKE_OSX_DEPLOYMENT_TARGET "10.15")
268270

269271
# copy bundle file

ci/mac/build_for_mac.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ fi
5858
mkdir $build_path
5959
cd $build_path
6060

61-
cmake_params="-DCMAKE_PREFIX_PATH=$qt_cmake_path -DCMAKE_BUILD_TYPE=$build_mode -DCMAKE_OSX_ARCHITECTURES=x86_64 -D CMAKE_OSX_DEPLOYMENT_TARGET=10.10"
61+
cmake_params="-DCMAKE_PREFIX_PATH=$qt_cmake_path -DCMAKE_BUILD_TYPE=$build_mode -DCMAKE_OSX_ARCHITECTURES=x86_64"
6262
cmake $cmake_params ../..
6363
if [ $? -ne 0 ] ;then
6464
echo "cmake failed"

0 commit comments

Comments
 (0)