Skip to content

Commit 796546e

Browse files
authored
merge(#3645): updated PKE image Cloudinfo request params
2 parents 04b6bf6 + 88dfdf5 commit 796546e

File tree

5 files changed

+28
-1
lines changed

5 files changed

+28
-1
lines changed

.gen/cloudinfo/api/openapi.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,14 @@ paths:
250250
type: string
251251
style: form
252252
x-go-name: Gpu
253+
- explode: true
254+
in: query
255+
name: cr
256+
required: false
257+
schema:
258+
type: string
259+
style: form
260+
x-go-name: Cr
253261
- explode: true
254262
in: query
255263
name: version

.gen/cloudinfo/api_images.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/cloudinfo/openapi.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,11 @@ paths:
222222
in: query
223223
schema:
224224
type: string
225+
- x-go-name: Cr
226+
name: cr
227+
in: query
228+
schema:
229+
type: string
225230
- x-go-name: Version
226231
name: version
227232
in: query

cmd/worker/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,8 +436,8 @@ func main() {
436436

437437
imageSelector := pkeaws.NewImageSelectorChain(commonLogger, errorHandler)
438438

439-
imageSelector.AddSelector("gpu", pkeaws.NewGPUImageSelector(pkeaws.GPUImages()))
440439
imageSelector.AddSelector("cloudinfo", pkeawsadapter.NewCloudinfoImageSelector(cloudinfoClient))
440+
imageSelector.AddSelector("gpu", pkeaws.NewGPUImageSelector(pkeaws.GPUImages()))
441441
if len(config.Distribution.PKE.Amazon.DefaultImages) > 0 {
442442
imageSelector.AddSelector("defaults", pkeaws.RegionMapImageSelector(config.Distribution.PKE.Amazon.DefaultImages))
443443
} else {

internal/cluster/distribution/pke/pkeaws/pkeawsadapter/image_selector.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ package pkeawsadapter
1616

1717
import (
1818
"context"
19+
"strconv"
20+
"strings"
1921

2022
"emperror.dev/errors"
2123
"github.com/Masterminds/semver/v3"
@@ -52,11 +54,18 @@ func (s CloudinfoImageSelector) SelectImage(ctx context.Context, criteria pkeaws
5254
)
5355
}
5456

57+
isGPUInstance := func(instanceType string) bool {
58+
return strings.HasPrefix(instanceType, "p2.") || strings.HasPrefix(instanceType, "p3.") ||
59+
strings.HasPrefix(instanceType, "g3.") || strings.HasPrefix(instanceType, "g4.")
60+
}
61+
5562
opts := &cloudinfo.GetImagesOpts{
5663
Version: optional.NewString(kubeVersion.String()),
5764
Os: optional.NewString(criteria.OperatingSystem),
5865
PkeVersion: optional.NewString(criteria.PKEVersion),
5966
LatestOnly: optional.NewString("true"),
67+
Gpu: optional.NewString(strconv.FormatBool(isGPUInstance(criteria.InstanceType))),
68+
Cr: optional.NewString(criteria.ContainerRuntime),
6069
}
6170

6271
const (

0 commit comments

Comments
 (0)