Skip to content

Commit 24af210

Browse files
committed
test: update to 120FPS in tests
1 parent 21492f1 commit 24af210

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

packages/commands/measure/src/__tests__/__snapshots__/measure.test.tsx.snap

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ Average Test Runtime
1111
Time taken to run the test.
1212
Can be helpful to measure Time To Interactive of your app, if the test is checking app start for instance.
1313
Average FPS
14-
60 FPS
15-
Frame Per Second. Your app should display 60 Frames Per Second to give an impression of fluidity. This number should be close to 60, otherwise it will seem laggy.
14+
120 FPS
15+
Frame Per Second. Your app should display 120 Frames Per Second to give an impression of fluidity. This number should be close to 120, otherwise it will seem laggy.
1616
1717
See
1818
@@ -34,7 +34,7 @@ RN JS Thread
3434
3535
0.5
3636
s
37-
High CPU usage by a single process can cause app unresponsiveness, even with low overall CPU usage. For instance, an overworked JS thread in a React Native app may lead to unresponsiveness despite maintaining 60 FPS.
37+
High CPU usage by a single process can cause app unresponsiveness, even with low overall CPU usage. For instance, an overworked JS thread in a React Native app may lead to unresponsiveness despite maintaining 120 FPS.
3838
Average RAM usage
3939
375.8 MB
4040
If an app consumes a large amount of RAM (random-access memory), it can impact the overall performance of the device and drain the battery more quickly.
@@ -106,11 +106,11 @@ Frame rate (FPS)
106106
"data": [
107107
{
108108
"x": 0,
109-
"y": 60
109+
"y": 120
110110
},
111111
{
112112
"x": 500,
113-
"y": 60
113+
"y": 120
114114
}
115115
]
116116
}
@@ -752,7 +752,7 @@ exports[`flashlight measure interactive it displays measures: Web app with measu
752752
<div
753753
class="text-neutral-300 whitespace-pre"
754754
>
755-
60 FPS
755+
120 FPS
756756
</div>
757757
<div
758758
class="w-2"
@@ -782,7 +782,7 @@ exports[`flashlight measure interactive it displays measures: Web app with measu
782782
<div
783783
class="text-neutral-400 text-sm"
784784
>
785-
Frame Per Second. Your app should display 60 Frames Per Second to give an impression of fluidity. This number should be close to 60, otherwise it will seem laggy.
785+
Frame Per Second. Your app should display 120 Frames Per Second to give an impression of fluidity. This number should be close to 120, otherwise it will seem laggy.
786786
<br />
787787
See
788788
<a
@@ -942,7 +942,7 @@ exports[`flashlight measure interactive it displays measures: Web app with measu
942942
- RN JS Thread for 0.5s
943943
</p>
944944
</div>
945-
High CPU usage by a single process can cause app unresponsiveness, even with low overall CPU usage. For instance, an overworked JS thread in a React Native app may lead to unresponsiveness despite maintaining 60 FPS.
945+
High CPU usage by a single process can cause app unresponsiveness, even with low overall CPU usage. For instance, an overworked JS thread in a React Native app may lead to unresponsiveness despite maintaining 120 FPS.
946946
</div>
947947
</div>
948948
</div>
@@ -1100,11 +1100,11 @@ exports[`flashlight measure interactive it displays measures: Web app with measu
11001100
"data": [
11011101
{
11021102
"x": 0,
1103-
"y": 60
1103+
"y": 120
11041104
},
11051105
{
11061106
"x": 500,
1107-
"y": 60
1107+
"y": 120
11081108
}
11091109
]
11101110
}
@@ -3813,7 +3813,7 @@ Time taken to run the test.
38133813
Can be helpful to measure Time To Interactive of your app, if the test is checking app start for instance.
38143814
Average FPS
38153815
-
3816-
Frame Per Second. Your app should display 60 Frames Per Second to give an impression of fluidity. This number should be close to 60, otherwise it will seem laggy.
3816+
Frame Per Second. Your app should display 120 Frames Per Second to give an impression of fluidity. This number should be close to 120, otherwise it will seem laggy.
38173817
38183818
See
38193819
@@ -3829,7 +3829,7 @@ An app might run at high frame rates, such as 60 FPS or higher, but might be usi
38293829
High CPU Usage
38303830
-
38313831
Impacted threads:
3832-
High CPU usage by a single process can cause app unresponsiveness, even with low overall CPU usage. For instance, an overworked JS thread in a React Native app may lead to unresponsiveness despite maintaining 60 FPS.
3832+
High CPU usage by a single process can cause app unresponsiveness, even with low overall CPU usage. For instance, an overworked JS thread in a React Native app may lead to unresponsiveness despite maintaining 120 FPS.
38333833
Average RAM usage
38343834
-
38353835
If an app consumes a large amount of RAM (random-access memory), it can impact the overall performance of the device and drain the battery more quickly.
@@ -4146,7 +4146,7 @@ exports[`flashlight measure interactive it displays measures: Web app with no me
41464146
<div
41474147
class="text-neutral-400 text-sm"
41484148
>
4149-
Frame Per Second. Your app should display 60 Frames Per Second to give an impression of fluidity. This number should be close to 60, otherwise it will seem laggy.
4149+
Frame Per Second. Your app should display 120 Frames Per Second to give an impression of fluidity. This number should be close to 120, otherwise it will seem laggy.
41504150
<br />
41514151
See
41524152
<a
@@ -4297,7 +4297,7 @@ exports[`flashlight measure interactive it displays measures: Web app with no me
42974297
Impacted threads:
42984298
</p>
42994299
</div>
4300-
High CPU usage by a single process can cause app unresponsiveness, even with low overall CPU usage. For instance, an overworked JS thread in a React Native app may lead to unresponsiveness despite maintaining 60 FPS.
4300+
High CPU usage by a single process can cause app unresponsiveness, even with low overall CPU usage. For instance, an overworked JS thread in a React Native app may lead to unresponsiveness despite maintaining 120 FPS.
43014301
</div>
43024302
</div>
43034303
</div>

packages/commands/test/src/__tests__/__snapshots__/PerformanceMeasurer.test.ts.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ exports[`PerformanceMeasurer handles c++ errors correctly 1`] = `
5959
"queued-work-loo (3)": 0,
6060
},
6161
},
62-
"fps": 60,
62+
"fps": 120,
6363
"ram": 375.76171875,
6464
"time": 500,
6565
},
@@ -120,7 +120,7 @@ exports[`PerformanceMeasurer handles c++ errors correctly 1`] = `
120120
"queued-work-loo (3)": 0,
121121
},
122122
},
123-
"fps": 60,
123+
"fps": 120,
124124
"ram": 375.76171875,
125125
"time": 1000,
126126
},

packages/commands/test/src/utils/test/mockChildProcess.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jest.mock("child_process", () => {
2222
case "adb shell getprop ro.build.version.sdk":
2323
return "30";
2424
case 'adb shell dumpsys display | grep -E "mRefreshRate|DisplayDeviceInfo"':
25-
return "fps=60";
25+
return "fps=120";
2626
case "adb shell setprop debug.hwui.profile true":
2727
case "adb shell atrace --async_stop 1>/dev/null":
2828
case "adb shell chmod 755 /data/local/tmp/BAMPerfProfiler":

0 commit comments

Comments
 (0)