Remove memory healthcheck

Supervisor has had memory leaks removed since v16.5.1, with latest tested
version being v16.7.1. Furthermore, on recent reported instances of memory healthcheck
triggering on support, we've snapshotted the heap before & after on devices multiple times
without finding any evidence of memory leaks in the snapshots.

Therefore, it's hypothesized that the heuristic for determining starting memory may
be flawed in that it's not waiting long enough after system startup, or it may
run right after garbage collection has happened. Because of the variability and
difficulty of ascertaining these factors, we suspect an inaccurate memory
baseline may be the cause of the instances of false positives on support.

See: https://balena.zulipchat.com/#narrow/channel/403752-channel.2Fsupport-help/topic/supervisor.20memory.20usage.20above.20threadhold/near/520640885
Change-type: patch
Signed-off-by: Christina Ying Wang <[email protected]>

Author: cywang117

src/memory.ts

@@ -7,7 +7,6 @@ import SupervisorAPI from './device-api';
 import * as v1 from './device-api/v1';
 import * as v2 from './device-api/v2';
 import logMonitor from './logging/monitor';
-import * as memory from './memory';
 
 import { initializeContractRequirements } from './lib/contracts';
 import { normaliseLegacyDatabase } from './lib/legacy';
@@ -72,11 +71,7 @@ export class Supervisor {
 				log.info('Starting API server');
 				this.api = new SupervisorAPI({
 					routers: [v1.router, v2.router],
-					healthchecks: [
-						apiBinder.healthcheck,
-						deviceState.healthcheck,
-						memory.healthcheck,
-					],
+					healthchecks: [apiBinder.healthcheck, deviceState.healthcheck],
 				});
 				deviceState.on('shutdown', () => this.api.stop());
 				return this.api.listen(conf.listenPort, conf.apiTimeout);