Merge pull request #1689 from balena-io-modules/fix-selection

Fix compatibility with selection without server side pagination

Author: JSReds

src/components/Filters/FilterModal.tsx

@@ -117,8 +117,10 @@ export const FilterModal = ({
 	const isValid = (
 		signs: FilterSignatureInternal[],
 	): signs is Array<
-		typeof signatures[number] &
-			Required<Pick<typeof signatures[number], 'field' | 'operator' | 'value'>>
+		(typeof signatures)[number] &
+			Required<
+				Pick<(typeof signatures)[number], 'field' | 'operator' | 'value'>
+			>
 	> =>
 		signs.every(
 			(s) => s.field && s.operator && s.value != null && s.value !== '',

src/components/Table/TableBase.tsx

@@ -391,7 +391,9 @@ export class TableBase<T extends {}> extends React.Component<
 	public toggleAllChecked = () => {
 		const { data, onCheck, rowKey, pagination } = this.props;
 
-		let checkedItems: T[] | undefined;
+		let checkedItems: T[] | undefined = !pagination?.serverSide
+			? []
+			: undefined;
 
 		if (
 			data &&

src/unstable-temp/DownloadImageModal/OsConfiguration.tsx

@@ -54,7 +54,7 @@ interface OsConfigurationProps {
 
 const BuildVariants = ['dev', 'prod'] as const;
 
-export type BuildVariant = typeof BuildVariants[number];
+export type BuildVariant = (typeof BuildVariants)[number];
 
 const getCategorizedVersions = (
 	deviceTypeOsVersions: OsVersionsByDeviceType,

src/unstable-temp/DownloadImageModal/OsTypeSelector.tsx

@@ -91,7 +91,7 @@ export const OsTypeSelector = ({
 	);
 
 	return (
-		<Select<typeof selectOsTypes[number]>
+		<Select<(typeof selectOsTypes)[number]>
 			id="newAppApplicationType"
 			options={selectOsTypes}
 			valueKey="slug"