Skip to content

Commit 4dd9240

Browse files
committed
Remove tag push events from release notes generation
Tag push events are only somewhat supported, and there is no situation where this ever would have worked since we need to look at the PR body and commits to generate notes. Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
1 parent be142b7 commit 4dd9240

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

.github/workflows/flowzone.yml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flowzone.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,15 +1382,12 @@ jobs:
13821382
timeout-minutes: ${{ fromJSON(inputs.jobs_timeout_minutes) }}
13831383
needs:
13841384
- versioned_source
1385-
# On tag push events, we only want to generate release notes if versioning is disabled.
1386-
# On pull_request events, we want to generate release notes if versioning is enabled.
1385+
# Only generate release notes on pull_request events, and only if versioning is enabled.
13871386
# Skip pull_request closed events, but allow pull_request merged events.
1388-
# By filtering on the tag output of versioned_source, we can ensure that this job
1389-
# only runs when versioning is enabled, or when a tag is pushed.
13901387
if: |
1391-
needs.versioned_source.outputs.tag != '' &&
1388+
inputs.disable_versioning != true &&
13921389
(
1393-
github.event.action != 'closed' ||
1390+
github.event.pull_request.state == 'open' ||
13941391
github.event.pull_request.merged == true
13951392
)
13961393

0 commit comments

Comments
 (0)