fix(rule): Fix to ignore link's title (#7)

Author: azu

package.json

@@ -34,14 +34,15 @@
   "dependencies": {
     "mdast-util-to-string": "^1.0.0",
     "sentence-splitter": "^2.0.0",
-    "textlint-rule-helper": "^2.0.0"
+    "textlint-rule-helper": "^2.0.0",
+    "textlint-util-to-string": "^2.1.1"
   },
   "devDependencies": {
     "babel-cli": "^6.1.18",
     "babel-plugin-add-module-exports": "^0.2.1",
     "babel-preset-es2015": "^6.1.18",
     "espower-babel": "^4.0.0",
-    "mocha": "^3.2.0",
+    "mocha": "^4.0.1",
     "power-assert": "^1.2.0",
     "textlint-tester": "^2.1.0"
   }

src/sentence-length.js

@@ -1,21 +1,19 @@
 // LICENSE : MIT
 "use strict";
-import {split} from "sentence-splitter";
-import toString from 'mdast-util-to-string';
-import {RuleHelper} from "textlint-rule-helper";
-const isStartWithNewLine = (text) => {
-    return text && text.charAt(0) === "\n";
-};
+import { split } from "sentence-splitter";
+import StringSource from 'textlint-util-to-string';
+import { RuleHelper } from "textlint-rule-helper";
+
 const defaultOptions = {
     max: 100
 };
 export default function(context, options = {}) {
     const maxLength = options.max || defaultOptions.max;
     const helper = new RuleHelper(context);
-    const {Syntax, RuleError, report} = context;
+    const { Syntax, RuleError, report } = context;
     // toPlainText
     return {
-        [Syntax.Paragraph](node){
+        [Syntax.Paragraph](node) {
             if (helper.isChildNode(node, [Syntax.BlockQuote])) {
                 return;
             }
@@ -24,24 +22,23 @@ export default function(context, options = {}) {
             if (isChildrenSingleLinkNode) {
                 return;
             }
-            const text = toString(node);
+            const source = new StringSource(node);
+            const text = source.toString();
             // empty break line == split sentence
             const sentences = split(text, {
                 newLineCharacters: "\n\n"
             });
             sentences.forEach(sentence => {
                 // TODO: should trim()?
-                let sentenceText = sentence.value;
+                const sentenceText = sentence.value;
                 // larger than > 100
                 if (sentenceText.length > maxLength) {
                     const currentLine = node.loc.start.line;
-                    const addedLine = isStartWithNewLine(sentenceText)
-                        ? sentence.loc.start.line // \n string
-                        : sentence.loc.start.line - 1; // string
-                    let paddingLine = Math.max(addedLine, 0);
-                    let paddingIndex = sentence.range[0];
-                    report(node, new RuleError(`Line ${currentLine + paddingLine} exceeds the maximum line length of ${maxLength}.`, {
-                        index: paddingIndex
+                    const start = source.originalPositionFromPosition(sentence.loc.start);
+                    const startLine = start.line - 1 + currentLine;
+                    const index = source.originalIndexFromPosition(sentence.loc.start);
+                    report(node, new RuleError(`Line ${startLine} exceeds the maximum line length of ${maxLength}.`, {
+                        index: index
                     }));
                 }
             });

test/sentence-length-test.js

@@ -25,7 +25,7 @@ tester.run("textlint-rule-sentence-length", rule, {
         },
         {
             // == 12345
-            text: "[123](http://example.com)45",
+            text: '[123](http://example.com "123456")45',
             options: {
                 max: 5
             }
@@ -94,7 +94,7 @@ Reduxの _Middleware_ は扱える範囲がdispatchからReducerまでと線引
             },
             errors: [
                 {
-                    message: `Line 5 exceeds the maximum line length of 100.`
+                    message: `Line 4 exceeds the maximum line length of 100.`
                 }
             ]
         }