Skip to content

Commit 2cccf26

Browse files
authored
[counters] skip showing counters that are not enabled (sonic-net#2199)
What I did Skip counters that are not enabled. How to verify it With change sonic-net/sonic-swss#2143, following commands will cause exception: admin@vlab-01:~$ show priority-group persistent-watermark headroom Traceback (most recent call last): File "/usr/local/bin/watermarkstat", line 315, in main() File "/usr/local/bin/watermarkstat", line 310, in main watermarkstat.print_all_stat(table_prefix, args.type) File "/usr/local/bin/watermarkstat", line 261, in print_all_stat data = self.get_counters(table_prefix, File "/usr/local/bin/watermarkstat", line 237, in get_counters elif fields[pos] != STATUS_NA: IndexError: list index out of range With the change: admin@vlab-01:~$ show priority-group persistent-watermark headroom Ingress headroom per PG: Port Ethernet0 Ethernet4 Ethernet8 Ethernet12 Ethernet16 ... ... Signed-off-by: Ying Xie [email protected]
1 parent ff05bc8 commit 2cccf26

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

scripts/watermarkstat

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,9 @@ class Watermarkstat(object):
226226

227227
# header list contains the port name followed by the queues/pgs. fields is used to populate the queue/pg values
228228
fields = ["0"]* (len(self.header_list) - 1)
229+
if not fields:
230+
# counters are not enabled.
231+
return fields
229232

230233
for name, obj_id in port_obj.items():
231234
full_table_id = table_prefix + obj_id

0 commit comments

Comments
 (0)