Move checks to Makefile

Signed-off-by: Aylei <[email protected]>

Author: aylei

.travis.yml

@@ -10,15 +10,8 @@ env:
 install:
   - go mod download
 
-before_script:
-  - GO_FILES=$(find . -iname '*.go' -type f | grep -v /vendor/) # All the .go files, excluding vendor/
-  - go get honnef.co/go/tools/cmd/staticcheck
-
 script:
-  - echo $GO_FILES | xargs gofmt -l                    # Fail if a .go file hasn't been formatted with gofmt
-  - go test -v -race ./...                             # Run all the tests with the race detector enabled
-  - go vet ./...                                       # go vet is the official Go static analyzer
-  - staticcheck ./...                                  # "go vet on steroids" + linter
+  - make check
 
 before_deploy:
   - make agent-docker

Makefile

@@ -1,7 +1,7 @@
-.PHONY: build plugin agent
+.PHONY: build plugin agent check
 
 GOENV  := GO15VENDOREXPERIMENT="1" GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=amd64
-GO := $(GOENV) go build
+GO := $(GOENV) go
 
 default: build
 
@@ -14,4 +14,9 @@ agent-docker: agent
 	docker build . -t aylei/debug-agent:latest
 
 agent:
-	$(GO) -o debug-agent cmd/agent/main.go
+	$(GO) build -o debug-agent cmd/agent/main.go
+
+check:
+	find . -iname '*.go' -type f | grep -v /vendor/ | xargs gofmt -l
+	GO111MODULE=on go test -v -race ./...
+	$(GO) vet ./...

pkg/plugin/cmd.go

@@ -231,7 +231,7 @@ func (o *DebugOptions) Complete(cmd *cobra.Command, args []string, argsLenAtDash
 			o.DebugAgentDaemonSet = defaultDaemonSetName
 		}
 	}
-	if config.PortForward == true {
+	if config.PortForward {
 		o.PortForward = true
 	}
 	o.Ports = []string{strconv.Itoa(o.AgentPort)}